[bkym7TcZ] Optimise apoc.refactor.cloneSubgraph #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loveleif
force-pushed
the
subgraph-performance
branch
from
b84bff8 to
1f4aadb
Compare
loveleif
changed the title
loveleif
commented
Oct 24, 2024
| assertEquals("ff", rel2.getProperty("ee")); | ||
| assertEquals("dd", rel2.getProperty("cc")); | ||
| assertNotNull(row.get("nodes")); | ||
| assertThat(row.get("nodes")) |
There was a problem hiding this comment.
I had some test failures of the unhelpful kind "false was not equal to true". So refactored some tests to help me out understanding that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option
createNodesInNewTransactionstoapoc.refactor.cloneSubgraphthat let's you control if nodes are created in inner transactions. Previous behavior was to create each node in a new transaction (relationships were not though, surprisingly). New default behavior is to use the outer transaction for all writes (createNodesInNewTransactions = truegives the old behavior still).