Update apoc help so that it does not rely on extended at all #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gem-neo4j
force-pushed
the
dev_apoc_help_update
branch
from
4ca1ff7 to
d098eaf
Compare
loveleif
approved these changes
Nov 20, 2024
| @@ -11,7 +11,7 @@ on: | |||
| - synchronize | |||
|
|
|||
| jobs: | |||
| validate-pr: | |||
| traceability: | |||
There was a problem hiding this comment.
I realised the traceability trigger didn't work for comments being added, and this was the culprit, so I snuck it in here
| "apoc.agg.slice"); | ||
| ; | ||
|
|
||
| public static final List<String> coreProcedures25 = List.of( |
There was a problem hiding this comment.
Not important, the other was called ...V5.
|
|
||
| public class HelpUtil { | ||
| // Please update here on the addition of any new procedures or functions! | ||
| public static final List<String> coreProceduresV5 = List.of( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APOC help was relying on a file existing in extended to know whether or not a function or procedure belonged to APOC core/extended. This felt superfluous, so have fixed it up.
(Also sneaky traceability fix)