Dev test cypher versions docker #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gem-neo4j
force-pushed
the
dev_test_cypher_versions_docker
branch
4 times, most recently
from
1cbc594 to
a3f1c85
Compare
gem-neo4j
commented
Feb 3, 2025
| ? System.getenv() | ||
| .getOrDefault( | ||
| "CYPHER_VERSION", | ||
| Util.getCypherVersion(GraphDatabaseInternalSettings.CypherVersion.Cypher25)) |
There was a problem hiding this comment.
Note: I will convert this back to 5 before merge, but wanted to show the tests are all fixed for Cypher 25 :D
loveleif
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Great! There's a merge conflict with https://github.com/neo-technology/neo4j/pull/29353, but I assume you will merge first so I get to handle that :).
gem-neo4j
force-pushed
the
dev_test_cypher_versions_docker
branch
from
a3f1c85 to
6a2b121
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to change Cypher version in Docker Tests