Regression: nested snippet expansion breaks initial snippet placeholder navigation

[oblitum]

Result from CocInfo

versions

vim version: NVIM v0.4.3
node version: v13.8.0
coc.nvim version: 0.0.74-d57f450e8d
term: tmux-256color
platform: linux

Messages

Output channel: clangd trace

I[00:43:49.836] clangd version 9.0.1
I[00:43:49.836] Working directory: /home/francisco/Projects/samples/c++
I[00:43:49.836] argv[0]: /usr/bin/clangd
I[00:43:49.836] Starting LSP over stdin/stdout
I[00:43:49.837] <-- initialize(0)
I[00:43:49.837] --> reply:initialize(0) 0 ms
I[00:43:49.840] <-- initialized
I[00:43:49.840] unhandled notification initialized
I[00:43:49.841] <-- textDocument/didOpen
I[00:43:49.841] Enqueueing 0 commands for indexing
I[00:43:49.841] --> textDocument/clangd.fileStatus
I[00:43:49.841] Updating file /home/francisco/Projects/samples/c++/sample.cpp with command
[/home/francisco/Projects/samples/c++]
/usr/bin/clang-tool -Wall -Wextra -pedantic -std=c++17 -stdlib=libc++ -I/opt/src/GSL/include -I/opt/src/range-v3/include /home/francisco/Projects/samples/c++/sample.cpp -fsyntax-only -resource-dir=/usr/lib/clang/9.0.1
I[00:43:49.853] --> textDocument/publishDiagnostics
I[00:43:49.853] --> textDocument/clangd.fileStatus

Output channel: git

Looking for git in: git

git rev-parse --show-toplevel
resolved root: /home/francisco
git ls-files -- Projects/samples/c++/sample.cpp
resolved root: /home/francisco
git symbolic-ref --short HEAD
git diff --name-status
git diff --staged --name-status
git ls-files --others --exclude-standard

Output channel: prettier

Output channel: snippets

Describe the bug

A clear and concise description of what the bug is.

This was implemented on #156, but have stopped working lately, it's not possible to jump placeholder when there's nested snippet expansion involved. This provides a bad experience as the user is forced to patch snippet code and remove placeholders manually.

Reproduce the bug

We will close your issue when you don't provide minimal vimrc and we can't
reproduce it

• Create file mini.vim with：

  let g:coc_global_extensions = ['coc-clangd']
  set runtimepath^=~/.vim/plugged/coc.nvim

• touch compile_flags.txt

• Start (neo)vim with command: nvim -u mini.vim sample.cpp

• Set content according to gif.

• Try to switch to next placeholder of outer snippet after finishing filling inner snippet.

Screenshots (optional)

If applicable, add screenshots to help explain your problem.

[oblitum]

Former commit fix was b1ad247.

[jackielii]

@oblitum can you try pr #1620 I suspect it'll fix this problem as well

[oblitum]

@jackielii I tried. It does not fix this. Also, it causes more issues, it doesn't jump correctly after the second snippet is expanded.

[chemzqm]

Hm, it doesn't work sometimes.