-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more nmap options to network discovery #64
Merged
leoparente
merged 13 commits into
develop
from
feat/OBS-820-network-discovery-enhancements
Mar 13, 2025
Merged
feat: add more nmap options to network discovery #64
leoparente
merged 13 commits into
develop
from
feat/OBS-820-network-discovery-enhancements
Mar 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go test coverage
Total coverage: 88.3% |
ltucker
approved these changes
Mar 13, 2025
mfiedorowicz
approved these changes
Mar 13, 2025
🎉 This PR is included in version 0.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and new features to the network discovery functionality. The changes include updates to configuration parameters, improvements to the policy runner, and new tests to ensure the functionality works as expected.
Configuration Enhancements:
Ports
,ExcludePorts
,Timing
,FastMode
,PingScan
,TopPorts
,ScanTypes
, andMaxRetries
to theScope
struct innetwork-discovery/config/config.go
.Policy Runner Improvements:
run
method innetwork-discovery/policy/runner.go
to handle the new configuration parameters and apply them to the nmap scanner options. This includes logic for handling different scan types, timing templates, and other scanning options.Testing Enhancements:
TestRunnerWithOptions
innetwork-discovery/policy/runner_test.go
to cover various combinations of the new configuration parameters and ensure they are correctly applied in the policy runner.Documentation Updates:
network-discovery/README.md
file to document the new configuration parameters and their usage.Workflow Improvements:
.github/workflows/network-discovery-tests.yaml
file to include a command that sets the necessary capabilities fornmap
to run with elevated privileges.