feat: add setFile() method
#26
Conversation
✅ Deploy Preview for blobs-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
type: feature
| @@ -1,3 +1,7 @@ | |||
| import { createReadStream } from 'node:fs' | |||
| import { stat } from 'node:fs/promises' | |||
| import { Readable } from 'node:stream' | |||
There was a problem hiding this comment.
Since this is also available as a Deno package, do you think it'd make sense to somehow use Deno-native FS APIs for this under Deno? e.g. by dependency-injecting an FS implementation?
There was a problem hiding this comment.
Deno now supports these native Node APIs, so these should work on both runtimes?
There was a problem hiding this comment.
Right, but presumably the native Deno APIs would be more performant? Probably doesn't make a difference, but could be interesting to at least do a measurement on it.
There was a problem hiding this comment.
OTOH, we probably won't upload a file from FS in Edge Functions in the foreseeable future, so scratch that 😅
Co-authored-by: Simon Knott <info@simonknott.de>
Which problem is this pull request solving?
Adds a
setFile(key: string, filePath: string)that reads a file fromfilePathand stores its contents on the blob store under the keykey.