Skip to content

Report deprecation messages when starting older Qx drivers #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 12, 2022

Conversation

jimklimov
Copy link
Member

@jimklimov jimklimov commented Apr 10, 2022

Seeing quite a few blazer_ser and blazer_usb mentions in the issue tracker (for varied NUT version TBH), I thought that it would be helpful to point users who copy-paste configurations from older tickets and blogs to try nutdrv_qx instead.

I looked for drivers whose source mentions "Q1" or "Q3" and came up with the ones in this PR:

  • bestups
  • blazer
  • masterguard

There are also some whose protocol I am not sure about, but per "fightwarn" effort they needed similar fixes (at least among themselves) :)

  • riello
  • bcmxcp
  • richcomm

@jimklimov jimklimov requested review from clepple, aquette and zykh April 10, 2022 13:00
@jimklimov jimklimov added this to the 2.8.0 milestone Apr 10, 2022
@jimklimov
Copy link
Member Author

Thinking of it, maybe the man pages should reflect this too.

For reviewers: is the wording generally okay to copy-paste further?

Copy link
Member

@clepple clepple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tripplite.c is the serial version of tripplite_usb.c, but it is not a Qx protocol, and is most likely not covered by nutdrv_qx (unless there was a refactoring that I was not aware of).

others LGTM.

@jimklimov
Copy link
Member Author

Thanks, updating it back :)

And document similarly in their man pages (bestups, blazer, masterguard)
@jimklimov jimklimov merged commit 923cfb6 into networkupstools:master Apr 12, 2022
@jimklimov jimklimov deleted the deprecation-qx branch April 12, 2022 15:14
jimklimov added a commit to jimklimov/nut that referenced this pull request Apr 14, 2022
@jimklimov jimklimov restored the deprecation-qx branch April 15, 2025 09:55
@jimklimov jimklimov deleted the deprecation-qx branch April 15, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants