Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always end call for everyone in one to one conversations #1629

Merged

Conversation

Ivansss
Copy link
Member

@Ivansss Ivansss commented Apr 19, 2024

Based on #1628

Draft until we implement it in all platforms

@Ivansss Ivansss requested a review from SystemKeeper April 19, 2024 16:31
@SystemKeeper
Copy link
Collaborator

Wondering if we should just change the default for 1:1 here. Tap -> End for all, Long press -> Option to just leave the call. I still can see occasions that I would like to leave a call without making the other leave the call as well? 🤔

@nickvergessen
Copy link
Member

Clarifying expectation:

  • One-to-one:
    • Short/Normal press: "End call" (Label is short, but behaviour is "End call for everyone")
    • Long press: "Leave call"
  • Group:
    • Short/Normal press: "Leave call"
    • Long press: "End call for everyone"

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
…tions and adjusted hang up button titles.

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss Ivansss force-pushed the always-end-call-for-everyone-in-one-to-one-conversations branch from ceac35d to ac63f8b Compare September 27, 2024 15:50
@Ivansss Ivansss marked this pull request as ready for review September 27, 2024 15:50
Copy link
Collaborator

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@SystemKeeper SystemKeeper merged commit 9b415b9 into master Oct 9, 2024
12 checks passed
@SystemKeeper SystemKeeper deleted the always-end-call-for-everyone-in-one-to-one-conversations branch October 9, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants