Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continuous Voice recording #1786

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Continuous Voice recording #1786

merged 1 commit into from
Nov 5, 2024

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Aug 30, 2024 •
edited
Loading

Current Demo

issue-618-1.mov

ToDo

  • Added a voice recording lock button
  • Added a new SwiftUI View for expanded voice recording
  • Stop AVAudioRecorder from ending and implement the send, delete, stop/restart buttons
  • Figure out how to deal with layout changes on orientation and with keyboard,

@rapterjet2004 rapterjet2004 self-assigned this Aug 30, 2024
@rapterjet2004 rapterjet2004 marked this pull request as ready for review September 6, 2024 15:12
SystemKeeper

This comment was marked as resolved.

Sign in to view

@SystemKeeper
Copy link
Collaborator

Really nice work otherwise, thanks a lot 👍

Ivansss

This comment was marked as resolved.

Sign in to view

@rapterjet2004 rapterjet2004 requested a review from Ivansss October 9, 2024 13:37
@SystemKeeper

This comment was marked as outdated.

Sign in to view
@SystemKeeper
Copy link
Collaborator

but maybe something like this is what you want to achieve?

You can do a similar thing for left and right anchor as well, if you don't like the visual layout format.

@rapterjet2004 rapterjet2004 force-pushed the issue-618-cont-voice-recording branch from 4be805e to 45c5f2b Compare October 10, 2024 14:12
@rapterjet2004
WIP Continous Voice recording
2572679 
- Added a voice recording lock button
- Added a new SwiftUI View for expanded voice recording

Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004 rapterjet2004 force-pushed the issue-618-cont-voice-recording branch from 45c5f2b to 2572679 Compare October 10, 2024 14:31
SystemKeeper
SystemKeeper approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see a few corner-cases here and there, but I think this is fine to do at some point in another PR. From my POV fine to merge. Thanks for the PR 👍

@rapterjet2004 rapterjet2004 requested review from Ivansss and removed request for Ivansss November 5, 2024 14:49
Ivansss
Ivansss approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your work here @rapterjet2004 :)
As @SystemKeeper said, there are small UI issues that could be tackled in a follow-up PR ;)

@Ivansss Ivansss merged commit 7c512b0 into master Nov 5, 2024
11 checks passed
@Ivansss Ivansss deleted the issue-618-cont-voice-recording branch November 5, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

@Ivansss Ivansss Ivansss approved these changes

Assignees

@rapterjet2004 rapterjet2004

Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting rid of the need to keep the record button pressed for voice messages
3 participants
@rapterjet2004 @SystemKeeper @Ivansss