-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed SettingsViewController not updating after clearing caches #1851
Conversation
Hey, thanks again for this PR! The only thing I am wondering: Did you see any threading issues? Everything should be done on the main thread already, the completion block for example is explicitly dispatched to main already: That's the only thing I am wondering right now (and is a bit nit-picky 😉). |
Fixes #1791 Signed-off-by: Daniel Standfest <daniel@standfest.io>
98c10c0
to
d3d1d5b
Compare
Hi, thank you for your review, Marcel. No problem with being nit-picky, I am eager to learn! I removed these parts now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks for the PR and the changes :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
Thanks a lot for your PR @DanielStandfest :)
/backport to stable20 |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Fixes #1791
@SystemKeeper