Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed SettingsViewController not updating after clearing caches #1851

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

DanielStandfest
Copy link
Contributor

@SystemKeeper
Copy link
Collaborator

Hey, thanks again for this PR!
I actually worked on that as well in this PR #1849. But I missed the completion block for the disk cache, which is nice. So I'll remove that commit from the PR and we can go ahead with yours :)

The only thing I am wondering: Did you see any threading issues? Everything should be done on the main thread already, the completion block for example is explicitly dispatched to main already:
https://github.com/SDWebImage/SDWebImage/blob/780aa6db621b7d195c31bab4d483879c1290d278/SDWebImage/Core/SDImageCache.m#L822-L831

That's the only thing I am wondering right now (and is a bit nit-picky 😉).

Fixes #1791

Signed-off-by: Daniel Standfest <daniel@standfest.io>
@DanielStandfest DanielStandfest force-pushed the fix-caches-not-updating branch from 98c10c0 to d3d1d5b Compare October 24, 2024 21:16
@DanielStandfest
Copy link
Contributor Author

DanielStandfest commented Oct 24, 2024

Hi, thank you for your review, Marcel.
Funny that we worked on the same issue at (nearly) the same time.

No problem with being nit-picky, I am eager to learn!
You are right and it seems that there are no threading issues after removing the dispatchqueue-main thread block.

I removed these parts now :)

Copy link
Collaborator

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for the PR and the changes :-)

Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍
Thanks a lot for your PR @DanielStandfest :)

@SystemKeeper SystemKeeper merged commit 6936968 into master Oct 28, 2024
11 checks passed
@SystemKeeper SystemKeeper deleted the fix-caches-not-updating branch October 28, 2024 16:48
@SystemKeeper
Copy link
Collaborator

/backport to stable20

Copy link

github-actions bot commented Nov 7, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SettingsViewController not updated after clearing caches
3 participants