Fix year-weighted sampling #1778
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storing it as integer has no additional benefits, since subsampling treats all groups (including date parts) as categorical.
Data types should match the metadata DataFrame, which reads all values as string. Interestingly, the default weight query needs to be updated - the previous equality check against 'default' worked with np.nan but no longer works with pd.NA. An explicit notna() condition is now necessary.
victorlin
force-pushed
the
victorlin/fix-year-weighted-sampling
branch
from
d64bea4 to
d0cd2fd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1778 +/- ##
=======================================
Coverage 73.21% 73.21%
=======================================
Files 79 79
Lines 8395 8395
Branches 1713 1713
=======================================
Hits 6146 6146
Misses 1960 1960
Partials 289 289 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Set should be used under the hood, but the order of sets is not guaranteed and it is best to have a guaranteed order for reproducibility. A simple alphabetical sort is sufficient. This became prominent when switching the internal representation of numeric columns such as 'year' from integer to string. The order of integers seems to be more consistent with sets compared to strings, and this was inadvertently relied upon in some functional tests.
victorlin
force-pushed
the
victorlin/fix-year-weighted-sampling
branch
from
d0cd2fd to
762324a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Ensure numeric metadata values are stored as string instead of integer.
Related issue(s)
Closes #1776
Checklist