Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump nf-schema to 2.4.1 #3533

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Conversation

nvnieuwk
Copy link
Contributor

This PR bumps nf-schema to 2.4.0 and Nextflow to 24.10.0 as this is the new minimal version for nf-schema

Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind

@maxulysse
Copy link
Member

Let's wait before we merge this one, 2.4.0 has a small issue that we discovered with @nvnieuwk

@nvnieuwk
Copy link
Contributor Author

Yes working on this now, hope to have the fix released by tomorrow

@maxulysse maxulysse changed the title bump nf-schema to 2.4.0 bump nf-schema to 2.4.1 Apr 10, 2025
nvnieuwk and others added 2 commits April 10, 2025 15:09
Co-authored-by: Maxime U Garcia <maxime.garcia@seqera.io>
Co-authored-by: Maxime U Garcia <maxime.garcia@seqera.io>
@nvnieuwk
Copy link
Contributor Author

Thanks @maxulysse !

@nvnieuwk
Copy link
Contributor Author

@mashehu any idea on what is going on with the CI here?

@mashehu
Copy link
Contributor

mashehu commented Apr 10, 2025

It's the branch protection rules. You need to update them for the new test names.

@nvnieuwk
Copy link
Contributor Author

Okay can you approve this PR first? That way I can directly merge it in after changing the branch protection and thus causing the least issues for all other PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants