Skip to content

Feat: Ansible backwards compatibility #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 10, 2022

Conversation

fidanf
Copy link
Contributor

@fidanf fidanf commented Feb 8, 2022

Proposed changes

Make role backward-compatble for Ansible versions 2.x, 3.x & 4 omitting recent module parameters when necessary.
Original PR and comments can be found here : #480
Looks like I cannot reopen it thus I must create a new one.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

Resolves #478

@alessfg alessfg added bug Something isn't working feature and removed bug Something isn't working labels Feb 9, 2022
@alessfg alessfg changed the title Cont: Feat ansible base compatibility Cont: Feat Ansible backwards compatibility Feb 10, 2022
@alessfg
Copy link
Member

alessfg commented Feb 10, 2022

Thanks for reopening the PR! Can you update the Changelog too?

@fidanf
Copy link
Contributor Author

fidanf commented Feb 10, 2022

Thanks for reopening the PR! Can you update the Changelog too?

Should I add a line into BUGFIXES of section 0.23 ?

@alessfg
Copy link
Member

alessfg commented Feb 10, 2022

I'd add it under FEATURES (you'll have to add a new section header). In a way it's not really a bug in so much as supporting older releases.

@alessfg alessfg changed the title Cont: Feat Ansible backwards compatibility Feat: Ansible backwards compatibility Feb 10, 2022
@alessfg alessfg merged commit 5b60ab6 into nginx:main Feb 10, 2022
@alessfg alessfg added this to the 0.22.1 milestone Feb 10, 2022
@alessfg
Copy link
Member

alessfg commented Feb 10, 2022

Merged -- thanks again!

@fidanf fidanf deleted the feat-ansible-base-compatibility branch February 10, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing ansible version check / usage of unsupported feature allow_downgrade
2 participants