Skip to content

Ensure gpg-agent is installed on Ubuntu #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2022
Merged

Ensure gpg-agent is installed on Ubuntu #508

merged 3 commits into from
Apr 11, 2022

Conversation

coaxial
Copy link
Contributor

@coaxial coaxial commented Apr 10, 2022

Proposed changes

Makes sure gpg-agent is present on Ubuntu systems before importing the apt keys, as outlined in #507.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg
Copy link
Member

alessfg commented Apr 10, 2022

I would probably add the package requirement here instead https://github.com/nginxinc/ansible-role-nginx/blob/main/vars/main.yml#L65 given it seems to be a hard requirement for Debian based systems.

@alessfg alessfg added the enhancement Enhance/improve an existing feature label Apr 10, 2022
@alessfg alessfg added this to the 0.23.2 milestone Apr 10, 2022
@alessfg alessfg linked an issue Apr 10, 2022 that may be closed by this pull request
@alessfg alessfg added bug Something isn't working and removed enhancement Enhance/improve an existing feature labels Apr 10, 2022
@coaxial
Copy link
Contributor Author

coaxial commented Apr 11, 2022

Thanks for the feedback, I have made the change.

Does this require a Molecule test added?

@alessfg
Copy link
Member

alessfg commented Apr 11, 2022

I think it's safe to assume most systems have gpg-agent installed. I don't know why the image created by geerlingguys's role does not? As such, creating a Molecule test for this specific use case might be more effort than it's worth. That being said, can you update the Changelog? I'll merge the PR once that's done.

@coaxial
Copy link
Contributor Author

coaxial commented Apr 11, 2022

Done.

@alessfg alessfg changed the title Ensure gpg-agent is installed on Ubuntu Ensure gpg-agent is installed on Ubuntu Apr 11, 2022
@alessfg alessfg merged commit 0cb3f22 into nginx:main Apr 11, 2022
@coaxial coaxial deleted the 507 branch April 11, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gpg-agent missing
2 participants