Migrate to VCDK #133
Open
Migrate to VCDK #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartoush
force-pushed
the
vcdk_migration
branch
2 times, most recently
from
1e027e8 to
67bd8f3
Compare
|
|
nigoroll
requested changes
May 21, 2025
README.rst
Outdated
| .. NB: This file is machine generated, DO NOT EDIT! | ||
| .. | ||
| .. Edit ./vmod_dynamic.vcc and run make instead | ||
| .. |
There was a problem hiding this comment.
as discussed oob, please keep the README.rst for general project info.
| [AC_MSG_WARN([extended resolver functions will not be available]) | ||
| AM_CONDITIONAL([HAVE_GETDNS], [false]) | ||
| AC_SUBST([VTC_TESTS], "$(cd $srcdir/src && echo tests/*.vtc tests/nogetdns/*.vtc)")]) | ||
| AC_SUBST([VTC_TESTS], "$(cd $srcdir/src && echo vtc/*.vtc vtc/nogetdns/*.vtc)")]) |
There was a problem hiding this comment.
(i did not check): Please make sure that you test with and without getdns
| -p vcl_path="$(abs_top_srcdir)/vcl:$(VARNISHAPI_VCLDIR)" \ | ||
| -p vmod_path="$(abs_builddir)/.libs:$(vmoddir):$(VARNISHAPI_VMODDIR)" | ||
|
|
||
| TESTS = \ |
There was a problem hiding this comment.
I would expect this to require some conditional on whether or not getdns is available
src/vmod_dynamic.c
Outdated
| @@ -100,8 +100,8 @@ static struct VSC_lck *lck_dir; | |||
|
|
|||
| static unsigned loadcnt = 0; | |||
|
|
|||
| static const struct gethdr_s HDR_REQ_HOST = { HDR_REQ, "\005Host:"}; | |||
| static const struct gethdr_s HDR_BEREQ_HOST = { HDR_BEREQ, "\005Host:"}; | |||
| static const struct gethdr_s HDR_REQ_HOST = { HDR_REQ, (void*)"\005Host:"}; | |||
There was a problem hiding this comment.
this is actually an adjustment required post VC 7.7, which is not related to the vcdk migration. I am going to address it separately.
src/vmod_dynamic.vcc
Outdated
| @@ -63,6 +63,119 @@ and weight though DNS. See https://en.wikipedia.org/wiki/SRV_record | |||
| for a good basic explanation and `xdirector.service()`_ for | |||
| details. | |||
|
|
|||
| Supported Operating Systems | |||
There was a problem hiding this comment.
This should move to a new INSTALL.rst
cartoush
force-pushed
the
vcdk_migration
branch
2 times, most recently
from
f674325 to
8d488c4
Compare
added 2 commits
May 23, 2025 14:39
Refactoring of this VMOD so that it corresponds to the schema described in https://git.sr.ht/~dridi/vcdk
Since VC 7.7, vmodtool.py generates a file that must be taken into account in Makefile.am https://varnish-cache.org/docs/trunk/whats-new/upgrading-7.7.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of this VMOD so that it corresponds
to the schema described in https://git.sr.ht/~dridi/vcdk