Add #[inline] to fspacectl to prevent linker errors with dylibs and --no-allow-shlib-undefined #2122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failures seem to be spurious. Maybe GCE briefly changed its seccomp settings, and then changed them back? |
…-no-allow-shlib-undefined
|
Strange... Yeah they seem to be working now. That's nice. |
asomers
approved these changes
Sep 23, 2023
|
@SteveLauC Can you make a patch release that contains this change? I'd really like to have the contents of this PR released so I can finish up rust-lang/rust#111769 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #2049 but for FreeBSD
Failed build is here: https://github.com/rust-lang-ci/rust/actions/runs/6066172674/job/16456459499
With patch: https://github.com/rust-lang-ci/rust/actions/runs/6069815522/job/16464786535
I modified Rust's CI a bit so that it tests all platforms on that PR (rust-lang/rust#111769), there should be no need for another PR after this.