Fix raw_pointer_derive warning #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, I tried a couple versions locally and the tests pass. @homu retry |
|
Ah, now I see. It is only when we are building the docs that things choke. It might work to invert the logic so that we allow unless we say that we should not have that behavior (might still get warnings when building docs, but who cares). |
|
Ah thanks for looking. I tried at every released version locally and was confused. |
This commit adds a small build script to detect if we need to `#[allow(raw_pointer_derive)]` and makes the attribute conditional. Refs nix-rust#337
kamalmarhubi
force-pushed
the
allow-raw-pointer-derive-warning
branch
from
9010e3c to
7c9524c
Compare
|
Flipped the logic, and filed rust-lang/cargo#2539 |
|
@homu r+ |
|
📌 Commit 7c9524c has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Apr 2, 2016
…=posborne Fix raw_pointer_derive warning This commit adds a small build script to detect if we need to `#[allow(raw_pointer_derive)]` and makes the attribute conditional. Refs #337
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a small build script to detect if we need to
#[allow(raw_pointer_derive)]and makes the attribute conditional.Refs #337