Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Screen object #1

Merged
merged 6 commits into from
Apr 22, 2021
Merged

Add Screen object #1

merged 6 commits into from
Apr 22, 2021

Conversation

nocarryr
Copy link
Owner

  • Add tslumd.tallyobj.Screen as a container for tslumd.tallyobj.Tally objects
  • Propagate all necessary events in a Screen from its child Tally objects
  • Message (Screen) and Display (Tally) processing is moved from UmdReceiver into Screen
  • UmdSender and UmdReceiver then primarily focus on handling Screen instances and events
  • Breaking changes are documented and primarily in the convenience methods of UmdSender
    since Tally objects are no longer addressable by index only, instead by (screen_index, tally_index)

- Make sure that tally updates from different screens are sent
  in separate messages
- Ensure that broadcast screens aren't periodically refreshed every
  time `UmdSender.send_full_update` is called (depending on `tx_interval`)
@nocarryr nocarryr merged commit 5846901 into main Apr 22, 2021
nocarryr added a commit to nocarryr/tallypi that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant