Skip to content

ARM cross compiler GCC 6 for Node >= 12 #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2019
Merged

ARM cross compiler GCC 6 for Node >= 12 #1776

merged 2 commits into from
Apr 18, 2019

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Apr 17, 2019

I now have GCC 6.5.0 and GCC 8.3.0 @ https://github.com/rvagg/rpi-newer-crosstools, which is already cloned to /opt/raspberrypi/rpi-newer-crosstools/ on the cross compiler machines (it needs an update). This update allows workers with new labels like "cross-compiler-armv7-gcc-6" to select GCC 6 for ARMv7. It still allows ARMv6 even though we're dropping that for Node 12, and we also don't need GCC 8 support yet but we get some flexibility here for experimentation.

I'd appreciate some sanity checking on the VersionSelectorScript before I merge this to try and avoid the problems with centos7 that I caused yesterday. Note the labels we currently use: https://ci.nodejs.org/view/All/job/node-cross-compile/, we'll also add "cross-compiler-armv7-gcc-6" to that list.

@rvagg
Copy link
Member Author

rvagg commented Apr 17, 2019

Closes #1731

@rvagg rvagg mentioned this pull request Apr 17, 2019
25 tasks
@rvagg
Copy link
Member Author

rvagg commented Apr 18, 2019

I'm going to bite the bullet, cross my fingers and put this into action, will have to do some testing across both ci and ci-release with different branches.

@rvagg rvagg merged commit 8b1f0a6 into master Apr 18, 2019
@rvagg rvagg deleted the rvagg/arm-cross branch April 18, 2019 07:09
@rvagg
Copy link
Member Author

rvagg commented Apr 18, 2019

Had to update with #1782 to get the host gcc-6 compiler onto the machines.

Confirmed working:

@refack I've changed pi2-docker to 'stretch' for node-test-binary-arm-12+, https://ci.nodejs.org/job/node-test-binary-arm-12+/108/ (#1783 is similar but for the scaleway armv7 machines).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant