Skip to content

tools: make mkssldef ignore DEPRECATEDIN #24329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

tools: make mkssldef ignore DEPRECATEDIN #24329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tools/mkssldef.py
View file
Original file line number Diff line number Diff line change
@@ -33,6 +33,8 @@
assert meta[2] in ('FUNCTION', 'VARIABLE')
if meta[0] != 'EXIST': continue
if meta[2] != 'FUNCTION': continue
# In cases where meta[3] is 'DEPRECATEDIN_X_Y,CATEGORY'
meta[3] = meta[3].split(',')[-1]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check that the zeroth field is what you expect it to be?

if ',' in meta[3]:
  fst, meta[3] = meta[3].split(',')
  assert fst.startswith('DEPRECATEDIN')

The above assumes at most two fields. You could also filter out all deprecation tags:

words = meta[3].split(',')
words = [word for word in words if not word.startswith('DEPRECATEDIN')]
assert len(words) == 1
meta[3] = words.pop()

def satisfy(expr, rules):
def test(expr):
if expr.startswith('!'): return not expr[1:] in rules