Skip to content

benchmark: remove unreachable return #25883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion benchmark/_cli.js
Original file line number Diff line number Diff line change
@@ -72,7 +72,6 @@ function CLI(usage, settings) {
} else {
// Bad case, abort
this.abort(usage);
return;
}
}
}
1 change: 0 additions & 1 deletion benchmark/common.js
Original file line number Diff line number Diff line change
@@ -169,7 +169,6 @@ Benchmark.prototype._run = function() {
child.on('close', (code) => {
if (code) {
process.exit(code);
return;
}

if (queueIndex + 1 < self.queue.length) {
2 changes: 0 additions & 2 deletions benchmark/compare.js
Original file line number Diff line number Diff line change
@@ -25,7 +25,6 @@ const cli = CLI(`usage: ./node compare.js [options] [--] <category> ...

if (!cli.optional.new || !cli.optional.old) {
cli.abort(cli.usage);
return;
}

const binaries = ['old', 'new'];
@@ -98,7 +97,6 @@ if (showProgress) {
child.once('close', function(code) {
if (code) {
process.exit(code);
return;
}
if (showProgress) {
progress.completeRun(job);
1 change: 0 additions & 1 deletion benchmark/run.js
Original file line number Diff line number Diff line change
@@ -67,7 +67,6 @@ if (format === 'csv') {
child.once('close', function(code) {
if (code) {
process.exit(code);
return;
}

// If there are more benchmarks execute the next
1 change: 0 additions & 1 deletion benchmark/scatter.js
Original file line number Diff line number Diff line change
@@ -17,7 +17,6 @@ const cli = CLI(`usage: ./node scatter.js [options] [--] <filename>

if (cli.items.length !== 1) {
cli.abort(cli.usage);
return;
}

// Create queue from the benchmarks list such both node versions are tested