doc: add riscv64 to list of architectures #49284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
approved these changes
Aug 22, 2023
|
If anyone is wondering where to get such a riscv64 Node.js build, see https://unofficial-builds.nodejs.org/ (nodejs/unofficial-builds#54). |
tniessen
approved these changes
Aug 22, 2023
VoltrexKeyva
approved these changes
Aug 23, 2023
richardlau
added
the
author ready
lpinca
approved these changes
Aug 23, 2023
PR-URL: nodejs#49284 Signed-off-by: Stewart X Addison <sxa@redhat.com>
|
(Force push to correct the PR_URL as I'd cut & pasted the issue link instead of the PR) |
aymen94
approved these changes
Aug 24, 2023
Setting the PR URL yourself in the commit message is really not necessary, our automation does that along with adding the names of those who approved the change. It doesn't hurt to add it manually, but you run into the risk of doing a typo. |
|
Landed in 3d0a317 |
Merged
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49284 Signed-off-by: Stewart X Addison <sxa@redhat.com> Fixes: nodejs#49278 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
added
the
dont-land-on-v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple doc change to add riscv64 to list of things that
os.arch()andprocess.archcan return.Fixes: #49278