fs: runtime deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` #49686

LiviaMedeiros · 2023-09-17T13:56:48Z

Follow-up from: #49683 (doc-only deprecation)

Opening this ahead of time to point out that the getters here are non-enumerable.

cc @nodejs/fs

richardlau · 2023-09-25T16:43:24Z

Given that we've only just doc-deprecated these #49683 (not in a release yet) I think it would be premature to runtime deprecate in Node.js 21. I'd have no objections to runtime deprecation in Node.js 22.

LiviaMedeiros · 2023-09-25T17:50:35Z

Sure; converting back to draft until v21.x is released.

The main point of opening it now was to see if there are any objections or suggestions to the implementation.
If we keep the getters with enumerable: true, the deprecation warning will be indirectly triggered by child_process; I don't know if there is any better workaround.

nodejs-github-bot · 2024-02-27T10:24:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57454/

juanarbol · 2024-11-03T05:17:32Z

@LiviaMedeiros this may needs rebase, this is a good timing for v24.x I think (?)

nodejs-github-bot · 2024-11-03T05:31:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63401/

LiviaMedeiros · 2024-11-03T05:33:09Z

Rebased on main.

cc @nodejs/tsc since it's semver-major

codecov · 2024-11-03T06:41:47Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (c2ff449) to head (7000c66).
Report is 74 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #49686      +/-   ##
==========================================
- Coverage   88.41%   88.40%   -0.02%     
==========================================
  Files         654      654              
  Lines      187594   187696     +102     
  Branches    36090    36114      +24     
==========================================
+ Hits       165870   165936      +66     
- Misses      14980    14996      +16     
- Partials     6744     6764      +20

Files with missing lines	Coverage Δ
lib/fs.js	`98.26% <100.00%> (+0.11%)`	⬆️

... and 34 files with indirect coverage changes

aduh95 · 2024-11-03T11:02:46Z

CITGM (main): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3499/
CITGM (this PR): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3500/

No related failure AFAICT

RafaelGSS · 2024-11-04T17:33:44Z

lib/fs.js

@@ -3274,10 +3275,50 @@ defineLazyProperties(
 );

 ObjectDefineProperties(fs, {


Can we have a test for it? We usually do something like https://github.com/nodejs/node/pull/55175/files#diff-4f2fa7a6febf9021fb93df3ec31e51b3bcbfb232a2b42bab8a1f7b496700646eR10

nodejs-github-bot · 2024-11-05T15:55:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/63430/

nodejs-github-bot · 2024-11-14T23:34:03Z

Landed in b02cd41

PR-URL: nodejs#49686 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Semver-Major Commits: buffer: * (SEMVER-MAJOR) make `buflen` in integer range (zhenweijin) #51821 build: * (SEMVER-MAJOR) bump supported macOS version to 13.5 (Michaël Zasso) #57115 * (SEMVER-MAJOR) increase minimum Xcode version to 16.1 (Michaël Zasso) #56824 * (SEMVER-MAJOR) link V8 with atomic library (Michaël Zasso) #55014 * (SEMVER-MAJOR) remove support for ppc 32-bit (Michaël Zasso) #55014 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #55014 child_process: * (SEMVER-MAJOR) deprecate passing `args` to `spawn` and `execFile` (Daniel Venable) #57199 deps: * (SEMVER-MAJOR) V8: cherry-pick f915fa4c9f41 (Olivier Flückiger) #55014 * (SEMVER-MAJOR) V8: cherry-pick 0d5d6e71bbb0 (Yagiz Nizipli) #55014 * (SEMVER-MAJOR) V8: cherry-pick 0c11feeeca4a (Michaël Zasso) #55014 * (SEMVER-MAJOR) define V8_PRESERVE_MOST as no-op on Windows (Stefan Stojanovic) #55014 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #55014 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #55014 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #55014 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #55014 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #55014 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #55014 * (SEMVER-MAJOR) update V8 to 13.0.245.25 (Michaël Zasso) #55014 * (SEMVER-MAJOR) upgrade npm to 11.0.0 (npm team) #56274 * (SEMVER-MAJOR) update undici to 7.0.0 (Node.js GitHub Bot) #56070 fs: * (SEMVER-MAJOR) remove ability to call truncate with fd (Yagiz Nizipli) #57567 * (SEMVER-MAJOR) remove `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #55862 * (SEMVER-MAJOR) deprecate passing invalid types in `fs.existsSync` (Carlos Espa) #55753 * (SEMVER-MAJOR) runtime deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #49686 * (SEMVER-MAJOR) remove `dirent.path` (Antoine du Hamel) #55548 lib: * (SEMVER-MAJOR) remove obsolete Cipher export (James M Snell) #57266 * (SEMVER-MAJOR) unexpose six process bindings (Michaël Zasso) #57149 * (SEMVER-MAJOR) make ALS default to AsyncContextFrame (Stephen Belanger) #55552 * (SEMVER-MAJOR) runtime deprecate SlowBuffer (Rafael Gonzaga) #55175 net: * (SEMVER-MAJOR) make _setSimultaneousAccepts() end-of-life deprecated (Yagiz Nizipli) #57550 repl: * (SEMVER-MAJOR) runtime deprecate instantiating without new (Aviv Keller) #54869 src: * (SEMVER-MAJOR) update GetForegroundTaskRunner override (Etienne Pierre-doray) #55014 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 134 (Michaël Zasso) #55014 * (SEMVER-MAJOR) drop --experimental-permission in favour of --permission (Rafael Gonzaga) #56240 * (SEMVER-MAJOR) add async context frame to AsyncResource (Gerhard Stöbich) #56082 * (SEMVER-MAJOR) nuke deprecated and un-used enum members in `OptionEnvvarSettings` (Juan José) #53079 stream: * (SEMVER-MAJOR) catch and forward error from dest.write (jakecastelli) #55270 test: * (SEMVER-MAJOR) disable fast API call count checks (Michaël Zasso) #55014 test_runner: * (SEMVER-MAJOR) remove promises returned by t.test() (Colin Ihrig) #56664 * (SEMVER-MAJOR) remove promises returned by test() (Colin Ihrig) #56664 * (SEMVER-MAJOR) automatically wait for subtests to finish (Colin Ihrig) #56664 timers: * (SEMVER-MAJOR) check for immediate instance in clearImmediate (Gürgün Dayıoğlu) #57069 * (SEMVER-MAJOR) set several methods EOL (Yagiz Nizipli) #56966 tls: * (SEMVER-MAJOR) remove deprecated tls.createSecurePair (Jonas) #57361 * (SEMVER-MAJOR) make server.prototype.setOptions end-of-life (Yagiz Nizipli) #57339 tools: * (SEMVER-MAJOR) update V8 gypfiles for 13.0 (Michaël Zasso) #55014 url: * (SEMVER-MAJOR) expose urlpattern as global (Jonas) #56950 * (SEMVER-MAJOR) runtime deprecate url.parse (Yagiz Nizipli) #55017 zlib: * (SEMVER-MAJOR) deprecate classes usage without `new` (Yagiz Nizipli) #55718 PR-URL: TBD

Semver-Major Commits: buffer: * (SEMVER-MAJOR) make `buflen` in integer range (zhenweijin) #51821 build: * (SEMVER-MAJOR) bump supported macOS version to 13.5 (Michaël Zasso) #57115 * (SEMVER-MAJOR) increase minimum Xcode version to 16.1 (Michaël Zasso) #56824 * (SEMVER-MAJOR) link V8 with atomic library (Michaël Zasso) #55014 * (SEMVER-MAJOR) remove support for ppc 32-bit (Michaël Zasso) #55014 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #55014 child_process: * (SEMVER-MAJOR) deprecate passing `args` to `spawn` and `execFile` (Daniel Venable) #57199 deps: * (SEMVER-MAJOR) V8: cherry-pick f915fa4c9f41 (Olivier Flückiger) #55014 * (SEMVER-MAJOR) V8: cherry-pick 0d5d6e71bbb0 (Yagiz Nizipli) #55014 * (SEMVER-MAJOR) V8: cherry-pick 0c11feeeca4a (Michaël Zasso) #55014 * (SEMVER-MAJOR) define V8_PRESERVE_MOST as no-op on Windows (Stefan Stojanovic) #55014 * (SEMVER-MAJOR) always define V8_NODISCARD as no-op (Michaël Zasso) #55014 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #55014 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #55014 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #55014 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #55014 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #55014 * (SEMVER-MAJOR) update V8 to 13.0.245.25 (Michaël Zasso) #55014 * (SEMVER-MAJOR) upgrade npm to 11.0.0 (npm team) #56274 * (SEMVER-MAJOR) update undici to 7.0.0 (Node.js GitHub Bot) #56070 fs: * (SEMVER-MAJOR) remove ability to call truncate with fd (Yagiz Nizipli) #57567 * (SEMVER-MAJOR) remove `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #55862 * (SEMVER-MAJOR) deprecate passing invalid types in `fs.existsSync` (Carlos Espa) #55753 * (SEMVER-MAJOR) runtime deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #49686 * (SEMVER-MAJOR) remove `dirent.path` (Antoine du Hamel) #55548 lib: * (SEMVER-MAJOR) remove obsolete Cipher export (James M Snell) #57266 * (SEMVER-MAJOR) unexpose six process bindings (Michaël Zasso) #57149 * (SEMVER-MAJOR) make ALS default to AsyncContextFrame (Stephen Belanger) #55552 * (SEMVER-MAJOR) runtime deprecate SlowBuffer (Rafael Gonzaga) #55175 net: * (SEMVER-MAJOR) make _setSimultaneousAccepts() end-of-life deprecated (Yagiz Nizipli) #57550 repl: * (SEMVER-MAJOR) runtime deprecate instantiating without new (Aviv Keller) #54869 src: * (SEMVER-MAJOR) update GetForegroundTaskRunner override (Etienne Pierre-doray) #55014 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 134 (Michaël Zasso) #55014 * (SEMVER-MAJOR) drop --experimental-permission in favour of --permission (Rafael Gonzaga) #56240 * (SEMVER-MAJOR) add async context frame to AsyncResource (Gerhard Stöbich) #56082 * (SEMVER-MAJOR) nuke deprecated and un-used enum members in `OptionEnvvarSettings` (Juan José) #53079 stream: * (SEMVER-MAJOR) catch and forward error from dest.write (jakecastelli) #55270 test: * (SEMVER-MAJOR) disable fast API call count checks (Michaël Zasso) #55014 test_runner: * (SEMVER-MAJOR) remove promises returned by t.test() (Colin Ihrig) #56664 * (SEMVER-MAJOR) remove promises returned by test() (Colin Ihrig) #56664 * (SEMVER-MAJOR) automatically wait for subtests to finish (Colin Ihrig) #56664 timers: * (SEMVER-MAJOR) check for immediate instance in clearImmediate (Gürgün Dayıoğlu) #57069 * (SEMVER-MAJOR) set several methods EOL (Yagiz Nizipli) #56966 tls: * (SEMVER-MAJOR) remove deprecated tls.createSecurePair (Jonas) #57361 * (SEMVER-MAJOR) make server.prototype.setOptions end-of-life (Yagiz Nizipli) #57339 tools: * (SEMVER-MAJOR) update V8 gypfiles for 13.0 (Michaël Zasso) #55014 url: * (SEMVER-MAJOR) expose urlpattern as global (Jonas) #56950 * (SEMVER-MAJOR) runtime deprecate url.parse (Yagiz Nizipli) #55017 zlib: * (SEMVER-MAJOR) deprecate classes usage without `new` (Yagiz Nizipli) #55718 PR-URL: #57609

nodejs-github-bot added fs needs-ci labels Sep 17, 2023

aduh95 added the semver-major label Sep 18, 2023

LiviaMedeiros added the blocked label Sep 20, 2023

LiviaMedeiros marked this pull request as ready for review September 20, 2023 07:15

LiviaMedeiros added deprecations and removed blocked labels Sep 25, 2023

LiviaMedeiros force-pushed the fs-runtime-deprecate-moisting-constants branch from 7a9498e to 956fcf1 Compare September 25, 2023 15:22

LiviaMedeiros marked this pull request as draft September 25, 2023 17:50

LiviaMedeiros marked this pull request as ready for review November 18, 2023 19:10

LiviaMedeiros force-pushed the fs-runtime-deprecate-moisting-constants branch 2 times, most recently from be1b1c3 to c865ced Compare February 26, 2024 10:49

LiviaMedeiros added the request-ci label Feb 26, 2024

github-actions bot removed the request-ci label Feb 26, 2024

This comment was marked as outdated.

Sign in to view

fs: runtime deprecate fs.F_OK, fs.R_OK, fs.W_OK, fs.X_OK

d5b465c

LiviaMedeiros force-pushed the fs-runtime-deprecate-moisting-constants branch from c865ced to d5b465c Compare November 3, 2024 05:28

squash: fix DEP number

5369c71

LiviaMedeiros added the commit-queue-squash label Nov 3, 2024

aduh95 approved these changes Nov 4, 2024

View reviewed changes

marco-ippolito approved these changes Nov 4, 2024

View reviewed changes

LiviaMedeiros added the author ready label Nov 4, 2024

RafaelGSS reviewed Nov 4, 2024

View reviewed changes

LiviaMedeiros added 3 commits November 5, 2024 22:44

squash: add test

5d01b37

squash: adjust test

37546ec

squash: lint

7000c66

jasnell approved these changes Nov 5, 2024

View reviewed changes

aduh95 added the commit-queue label Nov 14, 2024

nodejs-github-bot removed the commit-queue label Nov 14, 2024

nodejs-github-bot merged commit b02cd41 into nodejs:main Nov 14, 2024
55 checks passed

LiviaMedeiros mentioned this pull request Nov 15, 2024

fs: remove fs.F_OK, fs.R_OK, fs.W_OK, fs.X_OK #55862

Merged

RafaelGSS mentioned this pull request Mar 24, 2025

2025-04-23, Version 24.0.0 (Current) #57609

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fs: runtime deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` #49686

fs: runtime deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` #49686

LiviaMedeiros commented Sep 17, 2023 •

edited

Loading

richardlau commented Sep 25, 2023

LiviaMedeiros commented Sep 25, 2023

This comment was marked as outdated.

nodejs-github-bot commented Feb 27, 2024

juanarbol commented Nov 3, 2024

nodejs-github-bot commented Nov 3, 2024

LiviaMedeiros commented Nov 3, 2024

codecov bot commented Nov 3, 2024 •

edited

Loading

aduh95 commented Nov 3, 2024 •

edited

Loading

RafaelGSS Nov 4, 2024

nodejs-github-bot commented Nov 5, 2024

nodejs-github-bot commented Nov 14, 2024

		@@ -3274,10 +3275,50 @@ defineLazyProperties(
		);

		ObjectDefineProperties(fs, {

fs: runtime deprecate fs.F_OK, fs.R_OK, fs.W_OK, fs.X_OK #49686

fs: runtime deprecate fs.F_OK, fs.R_OK, fs.W_OK, fs.X_OK #49686

Conversation

LiviaMedeiros commented Sep 17, 2023 • edited Loading

richardlau commented Sep 25, 2023

LiviaMedeiros commented Sep 25, 2023

This comment was marked as outdated.

nodejs-github-bot commented Feb 27, 2024

juanarbol commented Nov 3, 2024

nodejs-github-bot commented Nov 3, 2024

LiviaMedeiros commented Nov 3, 2024

codecov bot commented Nov 3, 2024 • edited Loading

Codecov Report

aduh95 commented Nov 3, 2024 • edited Loading

RafaelGSS Nov 4, 2024

Choose a reason for hiding this comment

nodejs-github-bot commented Nov 5, 2024

nodejs-github-bot commented Nov 14, 2024

fs: runtime deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` #49686

fs: runtime deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` #49686

LiviaMedeiros commented Sep 17, 2023 •

edited

Loading

codecov bot commented Nov 3, 2024 •

edited

Loading

aduh95 commented Nov 3, 2024 •

edited

Loading