Skip to content

Make site work with the Cloudflare OpenNext adapter #7383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Jan 2, 2025

This PR applies changes to make it so that the site can be deployed to Cloudflare workers using the open-next Cloudflare adapter

The app does seem to work as intended for the most part:
Screenshot 2025-01-02 at 19 46 00

Deployment URL: https://nodejs-website.web-experiments.workers.dev


Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 8, 2025 11:14pm

@ovflowd
Copy link
Member

ovflowd commented Feb 1, 2025

@dario-piotrowicz do we have updates here? 👀

@dario-piotrowicz
Copy link
Member Author

Hey @ovflowd 👋

Sorry for keeping the PR lingering, there are a few smaller issues we addressed in our adapter (that I need to reflect here), and also ISR should be coming soon (@vicb can provide more context)

Besides that I just need to rebase the PR, the only significant issue remaining should be filesystem access, but I wanted to clarify that with you, I'll drop you a message today to clarify things

(PS: I hope the PR is not bothering you 🙇, if you want I can close it and reopen it when we're ready?)

@ovflowd
Copy link
Member

ovflowd commented Feb 16, 2025

Sorry for keeping the PR lingering, there are a few smaller issues we addressed in our adapter (that I need to reflect here), and also ISR should be coming soon (@vicb can provide more context)

This is awesome news. Excited to hear from @vicb

Besides that I just need to rebase the PR, the only significant issue remaining should be filesystem access, but I wanted to clarify that with you, I'll drop you a message today to clarify things

I believe we sorted that out on Slack 🖖

(PS: I hope the PR is not bothering you 🙇, if you want I can close it and reopen it when we're ready?)

Not at all <3

Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the reviews are resolved, LGTM

@avivkeller
Copy link
Member

Once #7383 (comment) #7383 (comment) resolve, this can probably land 🎉

@avivkeller
Copy link
Member

However, I would love if there was a test in the CI to verify this builds for any given push/PR.

@dario-piotrowicz
Copy link
Member Author

However, I would love if there was a test in the CI to verify this builds for any given push/PR.

mh... that's an interesting idea.... we've considered PR previews + e2es but not something that purely tests the build aspect of this 🤔

I wouldn't be against it, I am not sure how much extra confidence that would give us, but it'd definitely not hurt either (besides the potential extra noise etc...)

I'm totally happy to look into that 🙂
I think I'd prefer to do that as a followup PR and finally land this one, but I can also include it here if you prefer 🙂

@avivkeller
Copy link
Member

It can totally be a follow up, I just don't want us to have the unfortunate scenario where PR deploys successfully on Vercel, but not on OpenNext.

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after my final comments get addressed

@dario-piotrowicz
Copy link
Member Author

dario-piotrowicz commented May 8, 2025

LGTM after my final comments get addressed

Thanks Claudio 😃

There's still #7383 (comment) outstanding, please give it a quick look (it should be rather minor in any case)

@avivkeller
Copy link
Member

Did you link the right discussion? That one’s resolved with the conclusion that no changes are needed.

@dario-piotrowicz
Copy link
Member Author

Did you link the right discussion? That one’s resolved with the conclusion that no changes are needed.

Nope, sorry I pointed to the wrong one, thanks for spotting it, I've updated the link 🙂👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants