-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
Make site work with the Cloudflare OpenNext adapter #7383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Make site work with the Cloudflare OpenNext adapter #7383
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
b5e1217
to
0463451
Compare
@dario-piotrowicz do we have updates here? 👀 |
Hey @ovflowd 👋 Sorry for keeping the PR lingering, there are a few smaller issues we addressed in our adapter (that I need to reflect here), and also ISR should be coming soon (@vicb can provide more context) Besides that I just need to rebase the PR, the only significant issue remaining should be filesystem access, but I wanted to clarify that with you, I'll drop you a message today to clarify things (PS: I hope the PR is not bothering you 🙇, if you want I can close it and reopen it when we're ready?) |
This is awesome news. Excited to hear from @vicb
I believe we sorted that out on Slack 🖖
Not at all <3 |
542f172
to
2723110
Compare
2723110
to
3481f56
Compare
3481f56
to
f746d5c
Compare
f746d5c
to
4ff9d79
Compare
4ff9d79
to
fac63da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the reviews are resolved, LGTM
cc37851
to
56246da
Compare
Once #7383 (comment) #7383 (comment) resolve, this can probably land 🎉 |
However, I would love if there was a test in the CI to verify this builds for any given push/PR. |
mh... that's an interesting idea.... we've considered PR previews + e2es but not something that purely tests the build aspect of this 🤔 I wouldn't be against it, I am not sure how much extra confidence that would give us, but it'd definitely not hurt either (besides the potential extra noise etc...) I'm totally happy to look into that 🙂 |
It can totally be a follow up, I just don't want us to have the unfortunate scenario where PR deploys successfully on Vercel, but not on OpenNext. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after my final comments get addressed
Thanks Claudio 😃 There's still #7383 (comment) outstanding, please give it a quick look (it should be rather minor in any case) |
Did you link the right discussion? That one’s resolved with the conclusion that no changes are needed. |
Nope, sorry I pointed to the wrong one, thanks for spotting it, I've updated the link 🙂👍 |
This PR applies changes to make it so that the site can be deployed to Cloudflare workers using the open-next Cloudflare adapter
The app does seem to work as intended for the most part:

Deployment URL: https://nodejs-website.web-experiments.workers.dev
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.