Skip to content

feat: redesign the previous releases page #7630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Apr 29, 2025
Merged

feat: redesign the previous releases page #7630

merged 36 commits into from
Apr 29, 2025

Conversation

araujogui
Copy link
Member

@araujogui araujogui commented Apr 8, 2025 •
edited
Loading

Description

Redesign the Previous Releases page

Related Issues

Fixes #7445

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@vercel Vercel
Copy link

vercel bot commented Apr 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 28, 2025 5:02pm

@araujogui araujogui changed the title feat(releaseData): add minorVersions prop feat: redesign the previous releases page Apr 8, 2025
@araujogui araujogui force-pushed the feat/redesign-releases branch from fd432c4 to 1e0ad17 Compare April 11, 2025 22:15
@avivkeller
Copy link
Member

looks good so far! Way to go! I've left one nitpick, but I know this is still a draft

AugustinMauroy
AugustinMauroy reviewed Apr 16, 2025
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thing but there are a couple of things that need fine-tuning
V0 - v17 "Release Announcement" is throwing 404 because there are any post about that.

@araujogui araujogui marked this pull request as ready for review April 17, 2025 01:31
@araujogui araujogui requested a review from a team as a code owner April 17, 2025 01:31
@avivkeller
Copy link
Member

avivkeller commented Apr 17, 2025 •
edited
Loading

IMO the code name feels too small, like it's part of the modal content, I feel it like it should be prominent (if present).

Maybe something like "Node.js 22 'Jod'" as a header?

(I know I initially said to prefix the version w/ "v", but looking at the release lines, they aren't prefixed like that anywhere else)

Also, TYSM for tackling this ♥️

@bjohansebas
Copy link
Member

Wow, overall I like it.

Btw, now there's a horizontal scroll on that page.
imagen

@araujogui
Copy link
Member Author

Wow, overall I like it.

Btw, now there's a horizontal scroll on that page. imagen

Yeah, I will create a smaller badge size. I'm also wondering if the N-API version is relevant for the users majority

@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Apr 17, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 17, 2025 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 99 🟢 100 🟢 96 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@github-actions GitHub Actions
Copy link
Contributor

Unit Test Coverage Report

Title Lines Statements Branches Functions
@node-core/ui-components Coverage: 95%
 95.83% (161/168) 77.86% (102/131) 88.57% (31/35)
@nodejs/website Coverage: 86%
 84.15% (494/587) 74.32% (165/222) 86.77% (105/121)
Title Tests Skipped Failures Errors Time
@node-core/ui-components 24 0 💤 0 ❌ 0 🔥 4.961s ⏱️
@nodejs/website 156 0 💤 0 ❌ 0 🔥 6.536s ⏱️

bjohansebas
bjohansebas approved these changes Apr 26, 2025
View reviewed changes
Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this change

@bjohansebas bjohansebas added the github_actions:pull-request Trigger Pull Request Checks label Apr 26, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 26, 2025
AugustinMauroy
AugustinMauroy approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW awesome job done here !

@avivkeller
Copy link
Member

@araujogui Do you know the cause of https://git.1-hub.cnnodejs/nodejs.org/actions/runs/14713449783/job/41291282023?pr=7630?

@araujogui
Copy link
Member Author

@araujogui Do you know the cause of https://git.1-hub.cnnodejs/nodejs.org/actions/runs/14713449783/job/41291282023?pr=7630?

I have no idea, it works locally.

@araujogui
Copy link
Member Author

I only re-runned the workflow and it worked, weird

@avivkeller
Copy link
Member

#7630 (comment) #7630 (comment) are resolved, right?

If so, I think we can merge this!

@araujogui
Copy link
Member Author

#7630 (comment) #7630 (comment) are resolved, right?

If so, I think we can merge this!

It's resolved

@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Apr 29, 2025
@avivkeller avivkeller enabled auto-merge April 29, 2025 12:25
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 29, 2025
@avivkeller avivkeller added this pull request to the merge queue Apr 29, 2025
@avivkeller
Copy link
Member

Then, by the power invested in me, I now pronounce this PR merged!

Merged via the queue into nodejs:main with commit 0fec722 Apr 29, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovflowd ovflowd ovflowd left review comments

@avivkeller avivkeller avivkeller approved these changes

@aymen94 aymen94 aymen94 approved these changes

@canerakdas canerakdas canerakdas approved these changes

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redesign the Previous Releases page
8 participants
@araujogui @avivkeller @bjohansebas @AugustinMauroy @codecov-commenter @ovflowd @aymen94 @canerakdas