fix data url test #2580
Merged
fix data url test #2580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhafraDev
force-pushed
the
fix-data-url-test
branch
from
6f1ce16 to
4fa8a62
Compare
KhafraDev
commented
Jan 2, 2024
| if (leading) { | ||
| while (j > i && isASCIIWhitespace(str.charCodeAt(i))) --i |
There was a problem hiding this comment.
so unless str.length was 0 j > i would always be true... and we're decrementing from i, which means if isASCIIWhitespace(...) was true, i would be negative? Not sure why I didn't realize this before.
There was a problem hiding this comment.
also using i and j instead of lead and trail shouldn't have landed
fixup fixup
KhafraDev
force-pushed
the
fix-data-url-test
branch
from
4fa8a62 to
61803bc
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2580 +/- ##
==========================================
- Coverage 85.54% 84.71% -0.84%
==========================================
Files 76 80 +4
Lines 6858 7241 +383
==========================================
+ Hits 5867 6134 +267
- Misses 991 1107 +116 ☔ View full report in Codecov by Sentry. |
tsctx
reviewed
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2579
fix was easier than I expected, I just reverted the changes here for the most part.