Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! First off, thanks for the fantastic work here @nomeata. 😊
I stumbled upon arbtt earlier today and started working on an initial configuration. One thing I tried was creating tags for particular websites. Capturing this works great with a Chrome addon, but the output of
arbtt-stats
isn't as beautiful as it maybe could be:I feel that it would be much nicer to have this:
The same issue occurs for folders, where
/
and\
are replaced with underscores as well (Program_Files__x86__Google_Chrome_Application_chrome_exe
).This PR makes
replaceForbidden
a bit more lax by allowing.
,/
, and\
. As\
is a bit problematic as an escape character, I decided to replace it with a forward slash. While maybe not ideal, it makes Windows paths much nicer. Maybe it's also nice to allow parantheses, but I wanted to keep it minimal for now and only include the characters I would care about.Thanks!
Max