Skip to content

Add support for the table of contents block type #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mhall002
Copy link

@mhall002 mhall002 commented Nov 6, 2021

Description

Adds support for the table of contents block type.

Fixes # (issue)
#180

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added to the block integration tests following the divider changes as a guide.
If unit tests need to be added in addition to the integration ones let me know.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@KoditkarVedant
Copy link
Contributor

@mhall002 Changes LGTM. If you could resolve the conflicts by merging latest main branch. so, I can merge the PR.

@KoditkarVedant KoditkarVedant linked an issue Nov 6, 2021 that may be closed by this pull request
@mhall002 mhall002 force-pushed the feature/180-add-support-for-table-of-contents branch from 74d8ef5 to 3af7b98 Compare November 6, 2021 16:10
@KoditkarVedant KoditkarVedant merged commit 16a44c6 into notion-dotnet:main Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Table of contents block type
3 participants