Skip to content

431: Throw error if database id was not provided #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

KoditkarVedant
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #431

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@KoditkarVedant KoditkarVedant requested a review from Copilot April 12, 2025 11:45
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • Test/Notion.UnitTests/Notion.UnitTests.csproj: Language not supported
Comments suppressed due to low confidence (1)

Test/Notion.UnitTests/DatabasesClientTests.cs:509

  • The test currently checks only for a null databaseId. Since the implementation checks for whitespace as well, consider adding test cases for empty and whitespace strings to ensure full coverage.
public async Task RetrieveAsync_throws_argument_null_exception_if_database_id_is_null_or_empty()

@KoditkarVedant KoditkarVedant force-pushed the feature/431-throw-error-if-database-id-was-not-provided branch from faef59d to d31b0d2 Compare April 12, 2025 11:57
@KoditkarVedant KoditkarVedant force-pushed the feature/431-throw-error-if-database-id-was-not-provided branch from d31b0d2 to 80d32df Compare April 12, 2025 12:02
@KoditkarVedant KoditkarVedant merged commit 28ccc2c into main Apr 12, 2025
6 checks passed
@KoditkarVedant KoditkarVedant deleted the feature/431-throw-error-if-database-id-was-not-provided branch April 12, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throw error if Database.RetrieveAsync receives null or empty DatabaseId
1 participant