-
Notifications
You must be signed in to change notification settings - Fork 50
Add support for reading and writing Name & Caption properties to file blocks #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for reading and writing Name & Caption properties to file blocks #436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
…sure consistent JSON serialization Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… ensure it serializes consistently with the interface Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…JSON contract Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
Test/Notion.IntegrationTests/BlocksClientTests.cs:440
- [nitpick] Consider adding a comment to clarify why the file name is expected to automatically have a '.jpg' extension after being set, to aid future maintainers in understanding this behavior.
file.Name.Should().Be("Test file name.jpg");
…ly have a '.jpg' or other file extension💡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
Test/Notion.IntegrationTests/BlocksClientTests.cs:442
- Consider adding additional test cases to cover scenarios where the file's Name property may already include an expected extension versus when it should be auto-appended from the URL. This will help ensure consistent behavior across different file types.
file.Name.Should().Be("Test file name.jpg");
Description
Add support for reading and writing Name & Caption properties to file blocks
Fixes #435
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: