Skip to content

feat(core): support yarn berry in CNW #11528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 11, 2022
Merged

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Aug 10, 2022

Current Behavior

Create-nx-workspace fails when run in Yarn Berry

Expected Behavior

Create-nx-workspace and generators should successfully run in Yarn Berry

Related Issue(s)

Fixes #

Related story: nrwl/ci#24

@meeroslav meeroslav requested a review from vsavkin August 10, 2022 11:57
@vercel
Copy link

vercel bot commented Aug 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ❌ Failed (Inspect) Aug 11, 2022 at 5:09PM (UTC)

@meeroslav meeroslav enabled auto-merge (squash) August 11, 2022 17:09
@meeroslav meeroslav merged commit 36213b7 into nrwl:master Aug 11, 2022
rlindgren pushed a commit to rlindgren/nx that referenced this pull request Aug 11, 2022
- Run `yarn set version berry` to switch to latest Yarn version.
- Create `.yarnrc.yml` in root with following contents:
```yml
nodeLinker: node-modules
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have plans to support the default install strategy (pnp)? If not, what were the blockers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do. There are some parts of our codebase that explicitly look for node_modules folder and expect to see all packages there, so those would have to be resolved first.

But before all that, we still need to add support for Berry to our CI workflow generators.

@meeroslav meeroslav deleted the yarn-berry branch November 8, 2022 15:35
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants