Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react): add crystal mf support to host and remote #30424

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(react): add crystal mf support to host and remote #30424

wants to merge 1 commit into from

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Mar 19, 2025 •
edited
Loading

Current Behavior

The @nx/react host and remote generators currently use executors to support Module Federation

Expected Behavior

When bundler=rspack use Crystal Module Federation with no executors for Module Federation

Related Issues

#30391

@vercel Vercel
Copy link

vercel bot commented Mar 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2025 1:56pm

@Coly010 Coly010 self-assigned this Mar 19, 2025
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 19, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit ef2b52c.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 1m 9s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 18s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=90ff0... ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-28 14:14:57 UTC

@Coly010 Coly010 force-pushed the mf/crystal-react-rspack branch 5 times, most recently from 6b1678c to 5bbd239 Compare March 21, 2025 10:04
@Coly010 Coly010 marked this pull request as ready for review March 21, 2025 13:00
@Coly010 Coly010 requested review from a team as code owners March 21, 2025 13:00
@Coly010 Coly010 requested review from JamesHenry and jaysoo March 21, 2025 13:01
@Coly010 Coly010 marked this pull request as draft March 21, 2025 13:01
@Coly010 Coly010 force-pushed the mf/crystal-react-rspack branch 16 times, most recently from c4ea75e to 23641be Compare March 26, 2025 15:28
@Coly010 Coly010 force-pushed the mf/crystal-react-rspack branch 6 times, most recently from dee9678 to 1933b50 Compare March 27, 2025 10:58
@Coly010 Coly010 mentioned this pull request Mar 27, 2025
Open
4 tasks
@Coly010 Coly010 force-pushed the mf/crystal-react-rspack branch 6 times, most recently from afe91d7 to a801feb Compare March 28, 2025 12:37
@Coly010 Coly010 force-pushed the mf/crystal-react-rspack branch from a801feb to ef2b52c Compare March 28, 2025 13:54
@Coly010 Coly010 marked this pull request as ready for review March 28, 2025 14:23
@Coly010 Coly010 requested review from a team as code owners March 28, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry Awaiting requested review from JamesHenry JamesHenry is a code owner automatically assigned from nrwl/nx-js-reviewers

@jaysoo jaysoo Awaiting requested review from jaysoo jaysoo is a code owner automatically assigned from nrwl/nx-react-reviewers

At least 1 approving review is required to merge this pull request.

Assignees

@Coly010 Coly010

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Coly010