fix(misc): override customConditions when using an incompatible module resolution
#30477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 450a9c9.
☁️ Nx Cloud last updated this comment at |
Coly010
approved these changes
Mar 24, 2025
FrozenPandaz
approved these changes
Mar 25, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Mar 25, 2025
…ule resolution (#30477) ## Current Behavior In a few different places (Crystal plugins, executors, generators, helpers) where `ts-node` compiler options are overridden and `moduleResolution` is being set to something other than `node16`, `nodenext`, or `bundler`, an error can occur if the `customConditions` compiler option is being used. ## Expected Behavior When overriding the `ts-node` compiler options and changing forcing `moduleResolution` to have a value that's incompatible with `customConditions`, the latter should be unset (set to `null`) to avoid errors. ## Related Issue(s) Fixes # (cherry picked from commit 5dbe040)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
In a few different places (Crystal plugins, executors, generators, helpers) where
ts-nodecompiler options are overridden andmoduleResolutionis being set to something other thannode16,nodenext, orbundler, an error can occur if thecustomConditionscompiler option is being used.Expected Behavior
When overriding the
ts-nodecompiler options and changing forcingmoduleResolutionto have a value that's incompatible withcustomConditions, the latter should be unset (set tonull) to avoid errors.Related Issue(s)
Fixes #