Add framework linking for iOS builds. #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
approved these changes
May 5, 2025
There was a problem hiding this comment.
Thanks @freakboy3742. I'll get this incorporated into NumPy's main branch now.
|
Done in numpy/numpy#28904 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A backport of mesonbuild#14541 into the NumPy version of meson. That PR has been merged into master, for release in Meson 1.9.
When building for iOS, and Python is a dependency, linking against the Python framework is required. This is done automatically for all the standard library modules.
This behavior differs from macOS. On macOS, binary modules are linked with
-undefined dynamic_lookup; that option is marked as deprecated for the iOS compiler, so it can't be used.It also differs from Unix platforms that link against
libPython- the link must be against the framework, not the library, as iOS doesn't allow "normal" dynamic library linking. As a result, existinglink_libpythoncan't be used.