Skip to content

MAINT: use a PEP 639 project.license SPDX expression #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

jorenham
Copy link
Member

This resolves the following Python 3..13 build-time warning:

********************************************************************************
Please use a simple string containing a SPDX expression for `project.license`. You can also use `project.license-files`. (Both options available on setuptools>=77.0.0).

By 2026-Feb-18, you need to update your project and remove deprecated calls
or your builds will no longer be supported.

See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
********************************************************************************

See also

@jorenham
Copy link
Member Author

jorenham commented Apr 13, 2025

CI failure seens unrelated, see #135

@jorenham jorenham changed the title MAINT: use a PEP 639 project.license SPDX expression MAINT: use a PEP 639 project.license SPDX expression Apr 13, 2025
Copy link
Member

@Kai-Striega Kai-Striega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Can confirm that the CI changes are unrelated. I'd like to fix those first so that we don't have the same failing test on main. I'll (hopefully) merge this over the weekend.

Thanks for your work

@Kai-Striega
Copy link
Member

Merging as the underlying test failure has been fixed and the change is appropriate. Thanks @jorenham!

@Kai-Striega Kai-Striega merged commit 528aba0 into numpy:main Apr 16, 2025
0 of 9 checks passed
@Kai-Striega Kai-Striega added this to the 2.0 milestone Apr 16, 2025
@jorenham jorenham deleted the pep639 branch April 16, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants