Skip to content

Remove dash from main page title #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

jarrodmillman
Copy link
Member

Close #766

Brief description of what is fixed or changed

Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for numpy-org ready!

Name Link
🔨 Latest commit b412976
🔍 Latest deploy log https://app.netlify.com/sites/numpy-org/deploys/67895b3d5edf9f0008b95559
😎 Deploy Preview https://deploy-preview-819--numpy-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stefanv
Copy link
Contributor

stefanv commented Jan 16, 2025

@steppi I'd like to merge this, but I noticed in another PR you noted that we should not be editing translated files. Could you clarify whether it is OK for us to edit translations here, to correct technical issues like this one (and, before, like fixing the format of image captions, e.g.)?

@steppi
Copy link
Contributor

steppi commented Jan 17, 2025

@steppi I'd like to merge this, but I noticed in another PR you noted that we should not be editing translated files. Could you clarify whether it is OK for us to edit translations here, to correct technical issues like this one (and, before, like fixing the format of image captions, e.g.)?

Thanks for the ping @stefanv. This is fine to merge. I know how to clean up the conflicts in Crowdin now. Touching translations should be fine, afterwards we just have to delete the 110n_main branch that Crowdin creates. It will then attempt to create a new one with conflicts resolved. Crowdin is configured in such a way that translations won't be lost during this process, although this wasn't the case previously.

@steppi steppi merged commit 813e91b into numpy:main Jan 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove an extra dash from numpy.org website's title "NumPy - "
3 participants