Skip to content

Fix typo in validation.rst #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Fix typo in validation.rst #605

merged 1 commit into from
Feb 15, 2025

Conversation

stefmolin
Copy link
Contributor

@stefmolin stefmolin commented Feb 15, 2025

The docs now reference a non-existent rule (G08), which, based on #592, I believe should be GL08.

I also think that line is a little misleading since that does not apply to the pre-commit hook or numpydoc lint, which both use the AstValidator.

@stefanv stefanv merged commit 532cd7d into numpy:main Feb 15, 2025
30 of 31 checks passed
@mattgebert
Copy link
Contributor

I have just recently realized the hook runs on the AST, and will providing a new PR shortly (re-opened #591). Just figuring out how to write a test similar to the ones in test_validate_hook.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants