fix: Update output for brew_install and cleanup feat: multi suggestions for formulas #1316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of
brew install
, if no suitable formula was found, has changed. Before it was an error, now it is a warning with suggestions which formula could be meant.The function to find the most similar formula doesn't work anymore (
_get_formulas()
), because the path in brew and the logic has changed. But this is not necessary anymore, because brew provides the matching match.Example output:
The formulas can contain special characters. That is why the regex has been extended.
Rule brew_install and test test_brew_install are adjusted and cleaned up.
closes #1299