Skip to content

feat: Add org id support and org store link #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 24, 2024
Merged

Conversation

kristijanhusak
Copy link
Member

@kristijanhusak kristijanhusak commented Jan 24, 2024

This PR addresses several things:

Important

Breaking change: Mapping for org-insert-link is changed from <prefix>il (<leader>oil) to <prefix>li (<leader>oli).

@Maltimore
Copy link
Contributor

Could you comment on why the default mapping was changed away from <prefix>il?
I couldn't figure out what the original orgmode uses, but doesn't look to me like they use something similar to <prefix>li.
Obviously, the new mapping is not in line with all the other keymappings that insert something, so I'm sure you had a very good reason to change this!

@kristijanhusak
Copy link
Member Author

I changed it to be in line with store link mapping, so to store link you do <prefix>ls as "link store" and then you do <prefix>li as "link insert". Now when I think about it, I could've probably used <prefix>sl as "store link" and leave the old mapping for insert, but I'm not sure why I went the other way.

SlayerOfTheBad pushed a commit to SlayerOfTheBad/orgmode that referenced this pull request Aug 16, 2024
* feat: Add org id module

* feat: Add set/get property to api

* feat: Add org_store_link

* chore: Fix some types

* feat: Support id: hyperlink format

* feat: Expose setting headline id in api

* docs: Add docs for org id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add org-store-link and org-insert-link
2 participants