refactor(agenda): use extmarks to set tags in right column #683
Conversation
PriceHiller
force-pushed
the
refactor/agenda-extmark-tags
branch
2 times, most recently
from
9219bcf to
c39601e
Compare
|
Looks like the latest nightly causes the CI to fail. Not an issue with this PR. Running |
Since neovim/neovim@2e1f505, Neovim now explicitly requires the bufnr for `vim.lsp.util.apply_text_edits` to be fully resolved — meaning it cannot be 0 or null.
|
The test error should be fixed by the PR I opened at #684 If that gets merged I can rebase this on top of it and go from there |
PriceHiller
force-pushed
the
refactor/agenda-extmark-tags
branch
from
c39601e to
2ed85b9
Compare
|
Rebased on top of #684 since it got merged. |
|
Tags should re-align once you redraw the agenda with This is how it looks in Emacs: This is Neovim with wrapping disabled: And Neovim with wrapping enabled: |
|
I pushed a fix for the realigning after render. Let me know how it looks now. |
|
I didn't realize how orgmode on Emacs handles it before opening this PR -- so extmarks is kinda non-standard to the Emacs implementation.
It aligns much better now, but still doesn't dynamically reflow etc. like extmarks and alignment gets really out of sorts when the window width is small. It seems to match up with Emacs though. Would you be open to supporting a nonstandard (meaning not like Emacs) extmark approach as well hidden behind a config flag? I personally prefer the alignment of extmarks and the fact they take priority over long titles as well as working well on a single line without word wrapping. |
|
I guess we could add it. Add an |
Cool, then I'll close this PR and make a new one with the changes from master when I get a sec. |
Before this change:
Notice that the tags end up off screen and do not get shifted to align to the right side of the screen.
After this change:
Notice that the tags are correctly aligned when the window is resized. Tags are not off screen at all.