Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export_model tweak #1277

Merged
merged 5 commits into from
Feb 6, 2021
Merged

export_model tweak #1277

merged 5 commits into from
Feb 6, 2021

Conversation

zphang
Copy link
Collaborator

@zphang zphang commented Feb 6, 2021

Convert export_model to export paths:

  • model/{model_type}.p --> model/model.p
  • model/{model_type}.json --> model/config.json

Additionally:

  • Replace model_type with hf_pretrained_model_name_or_path to exported summary config.json

@codecov
Copy link

codecov bot commented Feb 6, 2021

Codecov Report

Merging #1277 (49be2c8) into master (84f2f5a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1277      +/-   ##
==========================================
- Coverage   48.47%   48.47%   -0.01%     
==========================================
  Files         163      163              
  Lines       11214    11213       -1     
==========================================
- Hits         5436     5435       -1     
  Misses       5778     5778              
Impacted Files Coverage Δ
jiant/proj/main/export_model.py 89.28% <100.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f2f5a...49be2c8. Read the comment docs.

@zphang zphang merged commit dbbb4e6 into nyu-mll:master Feb 6, 2021
@zphang zphang deleted the export_model_tweak branch February 6, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants