Avoid needless dependency on parameter .cmi by introducing Parameter_name.t
#3708
+411
−416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takes the place of any `Global_module.t` or `Global_module.Name.t` that is known to be the name of a parameter. Can't have parameters. (Notably, even the current half-worked-out plans for parameterized parameters would actually keep this type in many places, so this isn't as much in the way as one might think.)
This has the benefit of not loading the .cmi file for something whose signature we don't need (say because the parameter is only used as part of an instance name).
lukemaurer
changed the title
Global_module.Parameter_name.tParameter_name.t
|
For the record: the failing CI wrt arm64 happened before, and is unrelated to the PR. The CI is not required so we can still merge the PR. |
|
@riaqn please approve, then... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3172, though a bit more narrow to focus on just putting the new type in all the places.
The new type
Global_module.Parameter_name.ttakes the place of anyGlobal_module.torGlobal_module.Name.tthat is known to be the name of a parameter. Can't have parameters. (Notably, even the current half-worked-out plans for parameterized parameters would actually keep this type in many places, so this isn't as much in the way as one might think.)Concretely, the immediate benefit is that we no longer load the .cmi file of a parameter just because it's used in the name of an instance. (All that we actually need to check in
Foo[Bar:Baz]is (a) thatFooexpects aBar, (b) thatBazimplementsBar, and (c) thatFooandBazagree on whatBarsays, none of which requires loadingbar.cmi.) This is tested in the Dune-like tests by removing-Iflags that shouldn't be necessary.