Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: dune exec not updating arg0 #11559

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

test: dune exec not updating arg0 #11559

wants to merge 5 commits into from
+59 −22

Conversation

Alizter
Copy link
Collaborator

@Alizter Alizter commented Mar 23, 2025 •
edited
Loading

@Alizter Alizter mentioned this pull request Mar 23, 2025
Open
@Alizter Alizter changed the title feature: tests stanzas produce aliases test: dune exec not updating arg0 Mar 23, 2025
@Alizter
Copy link
Collaborator Author

Alizter commented Mar 23, 2025

I've pushed a fix and a refactoring commit which drops the arg[0] business from Proc.restore_cwd_and_execve. I don't think its productive for callers to have to pass the correct arg[0] and it simplifies many call sites.

@Leonidas-from-XIV
Copy link
Collaborator

@Alizter Is there a reason this is marked as draft? It seems fairly sensible to me, fixes a bug, overall I believe uncontroversial and passes all tests.

@Alizter Alizter marked this pull request as ready for review March 26, 2025 15:12
@maiste maiste added bug cli Command line related labels Apr 2, 2025
Leonidas-from-XIV
Leonidas-from-XIV approved these changes Apr 4, 2025
View reviewed changes
Alizter added 5 commits April 13, 2025 20:46
@Alizter
test: dune exec not updating arg0
a9dccef 
Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter
fix: set argv.(0) in Proc.restore_cwd_and_execve
039a989 
Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter
refactor: drop argv[0] from Proc.restore_cwd_and_execve
0f1499f 
Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter
test: change github11527 into a file test
22af272 
Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter
doc: improve documentation of Proc.restore_cwd_and_execve
46c7a22 
Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter
Copy link
Collaborator Author

Alizter commented Apr 13, 2025

@Leonidas-from-XIV @maiste I've rebased this so its ready for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leonidas-from-XIV Leonidas-from-XIV Leonidas-from-XIV approved these changes

@maiste maiste maiste approved these changes

Assignees
No one assigned
Labels
bug cli Command line related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dune exec passes surprising executable path to the executable
3 participants
@Alizter @Leonidas-from-XIV @maiste