chore: remove Pp.newline #11607
Draft
chore: remove Pp.newline #11607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… depexts Signed-off-by: Ali Caglayan <alizter@gmail.com>
This was added in ocaml#11560. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
This has the same semantics and we avoid Pp.newline. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
newline-crusade
branch
2 times, most recently
from
c37b5e3 to
1a7bcd5
Compare
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we remove all uses of
Pp.newline.We should avoid using
Pp.newlinesince it will simply insert a newline character in the underlying formatting engine and this doesn't play well with the other kinds of breaks. I don't believe that there is any sensible use-case for this so I have opted to replace all mentions ofPp.newlinewith the intended equivalent.The refactoring in
Locis a bit more advanced, but we basically update the code to use the more modern style.Marking this as a draft PR for now until I can work out the kinks in the test-suite.