Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] dunolint (2 packages) (0.0.20250310) #27594

Merged
merged 2 commits into from
Mar 13, 2025

Conversation

mbarbin
Copy link
Contributor

@mbarbin mbarbin commented Mar 10, 2025

A linter for build files in dune projects

This is an initial release so I can take ownership of the package namespace on opam, and allow early trials for interested parties.

@mbarbin
Copy link
Contributor Author

mbarbin commented Mar 10, 2025

Currently this depends on unreleased package pplumbing. I am unsure whether I should separate this into 2 PRs or not.

@mbarbin
Copy link
Contributor Author

mbarbin commented Mar 10, 2025

@shonfeder or @mseri I would like to request the help of an opam-repo admin to work with me on this PR if you're up for it.

I've noticed a failure in the windows ci. At the moment I haven't tested the package outside of ubuntu-latest. Is there a way to specify that this package isn't going to be available on windows for the time being? (and so the CI won't even try to build).

@shonfeder
Copy link
Contributor

Currently this depends on unreleased package pplumbing. I am unsure whether I should separate this into 2 PRs or not.

one PR with a few closely related packages is fine!

@mbarbin mbarbin marked this pull request as ready for review March 11, 2025 09:39
@shonfeder
Copy link
Contributor

As noted, I think the core_unix failures are out of band here, but there is none lower bounds error in https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/375309a0f6cc5d161a6b2441d840c7a1e5ebbdf2/variant/compilers,5.3,dunolint.0.0.20250310,lower-bounds :

[ERROR] The compilation of dunolint.0.0.20250310 failed at "dune build -p dunolint -j 255 @install".

#=== ERROR while compiling dunolint.0.0.20250310 ==============================#
# context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.5.3.0 | pinned(https://github.com/mbarbin/dunolint/releases/download/0.0.20250310/dunolint-0.0.20250310.tbz)
# path                 ~/.opam/5.3/.opam-switch/build/dunolint.0.0.20250310
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p dunolint -j 255 @install
# exit-code            1
# env-file             ~/.opam/log/dunolint-7-b77115.env
# output-file          ~/.opam/log/dunolint-7-b77115.out
### output ###
# (cd _build/default && /home/opam/.opam/5.3/bin/ocamlopt.opt -w -40 -w +a-4-40-41-42-44-45-48-66 -warn-error +a -open Base -open Fpath_base -open Dunolint.Std -g -I lib/dunolinter/src/.dunolinter.objs/byte -I lib/dunolinter/src/.dunolinter.objs/native -I /home/opam/.opam/5.3/lib/base -I /home/opam/.opam/5.3/lib/dunolint-lib -I /home/opam/.opam/5.3/lib/file-rewriter -I /home/opam/.opam/5.3/lib/fpath -I /home/opam/.opam/5.3/lib/fpath-base -I /home/opam/.opam/5.3/lib/loc -I /home/opam/.opam/5.3/lib/pp -I /home/opam/.opam/5.3/lib/pplumbing/err -I /home/opam/.opam/5.3/lib/pplumbing/pp-tty -I /home/opam/.opam/5.3/lib/ppx_compare/runtime-lib -I /home/opam/.opam/5.3/lib/ppx_enumerate/runtime-lib -I /home/opam/.opam/5.3/lib/ppx_hash/runtime-lib -I /home/opam/.opam/5.3/lib/ppx_here/runtime-lib -I /home/opam/.opam/5.3/lib/ppx_sexp_conv/runtime-lib -I /home/opam/.opam/5.3/lib/sexplib0 -I /home/opam/.opam/5.3/lib/sexps-rewriter -H /home/opam/.opam/5.3/lib/astring -H /home/opam/.opam/5.3/lib/base/base_internalhash_types -H /home/opam/.opam/5.3/lib/base/shadow_stdlib -H /home/opam/.opam/5.3/lib/csexp -H /home/opam/.opam/5.3/lib/dune-glob -H /home/opam/.opam/5.3/lib/dune-private-libs/dune_re -H /home/opam/.opam/5.3/lib/dunolint-lib/vendor_blang -H /home/opam/.opam/5.3/lib/dunolint-lib/vendor_vcs -H /home/opam/.opam/5.3/lib/dyn -H /home/opam/.opam/5.3/lib/fpath-sexp0 -H /home/opam/.opam/5.3/lib/ocaml/unix -H /home/opam/.opam/5.3/lib/ocaml_intrinsics_kernel -H /home/opam/.opam/5.3/lib/ordering -H /home/opam/.opam/5.3/lib/parsexp -H /home/opam/.opam/5.3/lib/re -H /home/opam/.opam/5.3/lib/seq -H /home/opam/.opam/5.3/lib/stdune -H /home/opam/.opam/5.3/lib/stdune/filesystem_stubs -intf-suffix .ml -no-alias-deps -open Dunolinter__ -o lib/dunolinter/src/.dunolinter.objs/native/dunolinter__Sexp_handler.cmx -c -impl lib/dunolinter/src/sexp_handler.pp.ml)
# File "lib/dunolinter/src/sexp_handler.ml", line 157, characters 18-29:
# 157 |             ~loc:(Loc.of_file ~path:(Sexps_rewriter.path sexps_rewriter))
#                         ^^^^^^^^^^^
# Error: Unbound value "Loc.of_file"
# Hint: Did you mean "in_file"?
# (cd _build/default && /home/opam/.opam/5.3/bin/ocamlc.opt -w -40 -w +a-4-40-41-42-44-45-48-66 -warn-error +a -open Base -open Fpath_base -open Dunolint.Std -g -bin-annot -bin-annot-occurrences -I lib/dunolinter/src/.dunolinter.objs/byte -I /home/opam/.opam/5.3/lib/base -I /home/opam/.opam/5.3/lib/dunolint-lib -I /home/opam/.opam/5.3/lib/file-rewriter -I /home/opam/.opam/5.3/lib/fpath -I /home/opam/.opam/5.3/lib/fpath-base -I /home/opam/.opam/5.3/lib/loc -I /home/opam/.opam/5.3/lib/pp -I /home/opam/.opam/5.3/lib/pplumbing/err -I /home/opam/.opam/5.3/lib/pplumbing/pp-tty -I /home/opam/.opam/5.3/lib/ppx_compare/runtime-lib -I /home/opam/.opam/5.3/lib/ppx_enumerate/runtime-lib -I /home/opam/.opam/5.3/lib/ppx_hash/runtime-lib -I /home/opam/.opam/5.3/lib/ppx_here/runtime-lib -I /home/opam/.opam/5.3/lib/ppx_sexp_conv/runtime-lib -I /home/opam/.opam/5.3/lib/sexplib0 -I /home/opam/.opam/5.3/lib/sexps-rewriter -H /home/opam/.opam/5.3/lib/astring -H /home/opam/.opam/5.3/lib/base/base_internalhash_types -H /home/opam/.opam/5.3/lib/base/shadow_stdlib -H /home/opam/.opam/5.3/lib/csexp -H /home/opam/.opam/5.3/lib/dune-glob -H /home/opam/.opam/5.3/lib/dune-private-libs/dune_re -H /home/opam/.opam/5.3/lib/dunolint-lib/vendor_blang -H /home/opam/.opam/5.3/lib/dunolint-lib/vendor_vcs -H /home/opam/.opam/5.3/lib/dyn -H /home/opam/.opam/5.3/lib/fpath-sexp0 -H /home/opam/.opam/5.3/lib/ocaml/unix -H /home/opam/.opam/5.3/lib/ocaml_intrinsics_kernel -H /home/opam/.opam/5.3/lib/ordering -H /home/opam/.opam/5.3/lib/parsexp -H /home/opam/.opam/5.3/lib/re -H /home/opam/.opam/5.3/lib/seq -H /home/opam/.opam/5.3/lib/stdune -H /home/opam/.opam/5.3/lib/stdune/filesystem_stubs -intf-suffix .ml -no-alias-deps -open Dunolinter__ -o lib/dunolinter/src/.dunolinter.objs/byte/dunolinter__Sexp_handler.cmo -c -impl lib/dunolinter/src/sexp_handler.pp.ml)
# File "lib/dunolinter/src/sexp_handler.ml", line 157, characters 18-29:
# 157 |             ~loc:(Loc.of_file ~path:(Sexps_rewriter.path sexps_rewriter))
#                         ^^^^^^^^^^^
# Error: Unbound value "Loc.of_file"
# Hint: Did you mean "in_file"?

@mbarbin
Copy link
Contributor Author

mbarbin commented Mar 12, 2025

Re: Loc.of_file my bad I made a mistake in the loc lower bound. I pushed an attempt to fix.

@shonfeder
Copy link
Contributor

All good here! Thanks very much for the care with the CI :) (riscv workers are still waiting, but they have passed in earlier runs)

@shonfeder shonfeder merged commit 906fb78 into ocaml:master Mar 13, 2025
1 of 3 checks passed
@mbarbin mbarbin deleted the dunolint branch March 13, 2025 14:15
@mbarbin
Copy link
Contributor Author

mbarbin commented Mar 13, 2025

Amazing, thanks a lot @shonfeder. Please know that I very much appreciated your help as well as your encouraging comments. Talk soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants