Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rocq 9.0 release + Coq 9.0 compatibility packages #27613

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mattam82
Copy link
Contributor

@mattam82 mattam82 commented Mar 12, 2025

@mattam82 mattam82 marked this pull request as draft March 12, 2025 15:41
mattam82 added a commit to mattam82/opam-repository that referenced this pull request Mar 12, 2025
mattam82 added a commit to mattam82/opam-repository that referenced this pull request Mar 12, 2025
Copy link
Contributor

@proux01 proux01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also missing a coq metapackage, something along the lines

synopsis: "Compatibility metapackage for Coq after the Rocq renaming"
maintainer: ["The Rocq development team <coqdev@inria.fr>"]
authors: ["The Rocq development team, INRIA, CNRS, and contributors"]
license: "LGPL-2.1-only"
homepage: "https://coq.inria.fr/"
doc: "https://coq.github.io/doc/"
bug-reports: "https://github.com/coq/coq/issues"
depends: [
  "rocq-prover" {= version}
  "coq-core" {= version}
  "coq-stdlib" {= "9.0.0"}
  "coqide-server" {= version}
]
dev-repo: "git+https://github.com/coq/coq.git"

as well as the coqide-server package.

@SkySkimmer
Copy link
Contributor

The "lower bounds" jobs are failing on ocaml 5.x
This may be related to whatever the ocamlfind changelog means by "1.9.6:: Support for OCaml-5 (as far as foreseeable) (David Allsopp)" as we see CI downgrade ocamlfind 1.9.8 to 1.9.5 (we advertise compatibility with ocamlfind down to 1.8.1 but I guess some other bound stops it from downgrading that low, on ocaml 4.09 it did downgrade to 1.8.1)

@mattam82
Copy link
Contributor Author

This is also missing a coq metapackage, something along the lines

synopsis: "Compatibility metapackage for Coq after the Rocq renaming"
maintainer: ["The Rocq development team <coqdev@inria.fr>"]
authors: ["The Rocq development team, INRIA, CNRS, and contributors"]
license: "LGPL-2.1-only"
homepage: "https://coq.inria.fr/"
doc: "https://coq.github.io/doc/"
bug-reports: "https://github.com/coq/coq/issues"
depends: [
  "rocq-prover" {= version}
  "coq-core" {= version}
  "coq-stdlib" {= "9.0.0"}
  "coqide-server" {= version}
]
dev-repo: "git+https://github.com/coq/coq.git"

as well as the coqide-server package.

There are in a separate PR (along with rocqide) to not slow down this one, i.e. #27614

@proux01
Copy link
Contributor

proux01 commented Mar 13, 2025

There are in a separate PR (along with rocqide) to not slow down this one, i.e. #27614

Why not but coqide-server is usually ok, since it does not depend from lablgtk.

@mattam82
Copy link
Contributor Author

There are in a separate PR (along with rocqide) to not slow down this one, i.e. #27614

Why not but coqide-server is usually ok, since it does not depend from lablgtk.

Oh right, I missed that.

@mattam82
Copy link
Contributor Author

The ocaml-ci problems with "no-source" are similar to #27237 , for our compatibility metapackages that do not build or install anything by themselves.

mattam82 added a commit to mattam82/opam-repository that referenced this pull request Mar 15, 2025
mattam82 added a commit to mattam82/opam-repository that referenced this pull request Mar 15, 2025
@mattam82 mattam82 marked this pull request as ready for review March 15, 2025 20:50
@mattam82 mattam82 mentioned this pull request Mar 16, 2025
mattam82 and others added 2 commits March 17, 2025 22:15
Apply suggestions from code review
coqide-server and coq compat package
Remove with-test target as in 8.* packages

Co-authored-by: Gaëtan Gilbert <gaetan.gilbert@skyskimmer.net>
Co-authored-by: Pierre Roux <pierre.roux@onera.fr>
@mattam82
Copy link
Contributor Author

Now rebased on revdeps fix

mattam82 added a commit to mattam82/opam-repository that referenced this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants