Add 'install --formula', rewrite '--deps-only' #4975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AltGr
force-pushed
the
install-formula
branch
from
4bacf33 to
4433dfa
Compare
|
Should be finished, just needs some git history cleanup + tests |
AltGr
force-pushed
the
install-formula
branch
2 times, most recently
from
e723653 to
8957e01
Compare
AltGr
changed the title
rjbou
requested review from
rjbou and
kit-ty-kate
and removed request for
rjbou
|
|
rjbou
force-pushed
the
install-formula
branch
from
ab6cd0b to
b1165cd
Compare
kit-ty-kate
added
the
PR: QUEUED
rjbou
force-pushed
the
install-formula
branch
from
b1165cd to
1234610
Compare
rjbou
removed
the
PR: QUEUED
kit-ty-kate
reviewed
Feb 22, 2022
kit-ty-kate
approved these changes
Feb 22, 2022
AltGr
force-pushed
the
install-formula
branch
from
92689cb to
8c03bbc
Compare
|
rebased |
|
closes #4914 |
rjbou
added
the
PR: QUEUED
rjbou
removed
the
PR: QUEUED
Using the same scheme as for enforcing the invariant (but with a distinct path, we don't want the two to get confused in messages, etc.) This is only in the internal API at the moment. The `request` type is extended to allow a formula (instead of an atom list) in its `wish_install` field.
Working around a set of bugs that were in the original version, but also renouncing using the `--formula` code path because that was too limited for using deps-only on multiple packages, and with unspecified versions. This creates virtual packages at the client level that mimic the dependencies of the specified packages (except for dependencies between them). This resolves a few issues: - these packages are always available (the original implem patched the packages but that could result in unavailable packages getting installed) ; they are however marked as avoid-version if unavailable as a cheap way to stay on the right version when possible. - they exist in parallel to their "real" counterpart, so that these can still be installed if required through dependency chains, keeping consistency of the solution. - they forbid different versions of their "real" counterpart, to ensure consistency. - the `deps-of-xxx` package are removed from the solution, but could appear in conflict messages. I'd argue that it should make things understandable even if it is an implementation detail.
…experimental For printing of action reasons with `--formula`, unfortunately we have to add yet another argument, because the `requested` for applying `--with-test` and similar flags no longer matches the one used for printing actions reasons: the former doesn't include packages specified through `--formula` while the latter needs to.
Formula remains strict, the best effort only concerns the individual atoms.
LasseBlaauwbroek
added a commit
to LasseBlaauwbroek/opam
that referenced
this pull request
Aug 26, 2022
In PR ocaml#4796 I fixed a problem with `--best-effort`. Subsequently ocaml#4975 seems to have broken this again. Not sure if this is the correct fix. There may also be additional places where this is going wrong...
kit-ty-kate
pushed a commit
to LasseBlaauwbroek/opam
that referenced
this pull request
Aug 31, 2022
In PR ocaml#4796 I fixed a problem with `--best-effort`. Subsequently ocaml#4975 seems to have broken this again. Not sure if this is the correct fix. There may also be additional places where this is going wrong...
kit-ty-kate
pushed a commit
to LasseBlaauwbroek/opam
that referenced
this pull request
Aug 31, 2022
In PR ocaml#4796 I fixed a problem with `--best-effort`. Subsequently ocaml#4975 seems to have broken this again. Not sure if this is the correct fix. There may also be additional places where this is going wrong...
kit-ty-kate
added a commit
that referenced
this pull request
Sep 1, 2022
Fix --best-effort regression introduced in #4975
Leonidas-from-XIV
pushed a commit
to Leonidas-from-XIV/opam
that referenced
this pull request
Mar 10, 2023
In PR ocaml#4796 I fixed a problem with `--best-effort`. Subsequently ocaml#4975 seems to have broken this again. Not sure if this is the correct fix. There may also be additional places where this is going wrong...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.