Compiler packages into invariant packages #5208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
added
PR: QUEUED
rjbou
force-pushed
the
invariant-packages
branch
2 times, most recently
from
8ffcfd0 to
33f86fc
Compare
rjbou
force-pushed
the
invariant-packages
branch
from
33f86fc to
28beadc
Compare
rjbou
force-pushed
the
invariant-packages
branch
from
28beadc to
bdd0dfd
Compare
kit-ty-kate
reviewed
Sep 1, 2022
kit-ty-kate
reviewed
Sep 1, 2022
4 tasks
rjbou
added
PR: QUEUED
rjbou
force-pushed
the
invariant-packages
branch
from
bdd0dfd to
6540dd7
Compare
rjbou
force-pushed
the
invariant-packages
branch
from
6540dd7 to
b980c6f
Compare
rjbou
removed
the
PR: QUEUED
kit-ty-kate
reviewed
Nov 11, 2022
| @@ -14,6 +14,7 @@ The following actions will be performed: | |||
|
|
|||
| <><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><> | |||
| -> installed foo.1 | |||
| [WARNING] Undefined filter variable build in dependencies of foo.1 | |||
There was a problem hiding this comment.
yes, because we recompute and re-resolve at new switch state recording
rjbou
commented
Nov 14, 2022
1 task
rjbou
force-pushed
the
invariant-packages
branch
from
aadafc5 to
2751af2
Compare
AltGr
approved these changes
Feb 8, 2023
rjbou
force-pushed
the
invariant-packages
branch
from
2751af2 to
5ffabe9
Compare
rjbou
force-pushed
the
invariant-packages
branch
from
5ffabe9 to
548cea3
Compare
rjbou
force-pushed
the
invariant-packages
branch
from
548cea3 to
f7ce25f
Compare
|
Removed |
dra27
force-pushed
the
invariant-packages
branch
from
f7ce25f to
47a8c26
Compare
|
lgtm! |
dra27
force-pushed
the
invariant-packages
branch
2 times, most recently
from
8831b41 to
706a134
Compare
Since invariant is defined and updated, compiler_packages is no more consistent the way it is. To keep field name, it is still named `compiler-packages`, but its content is now invariant formula installed packages and their recursive dependencies. It implies also that switch state need to be update at each time an install/removal is done, or invariant changed. * Remove `universe.u_base` field * Compute invariant packages instead of compiler packages * Change PEF `base` field into `invariant-pkg`
* opam list --invariant instead of --base * change column name to invariant * display invariant packages instead of compiler ones
dra27
force-pushed
the
invariant-packages
branch
from
706a134 to
1eb1ea3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since invariant is defined and updated, compiler_packages is no more
consistent the way it is. To keep field name, it is still named
compiler-packages, but its content is now invariant formula installedpackages and their recursive dependencies. It implies also that switch
state need to be update at each time an install/removal is done, or
invariant changed.
universe.u_basefieldbasefield intoinvariant-pkg--invariantinstead of--basefix #5202
fix #5201