Replace every use of GNU Patch by the OCaml patch library #5892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
commented
Mar 21, 2024
|
Could be coupled with ocaml-patch's implementation of diff via hannesm/patch#12 |
kit-ty-kate
force-pushed
the
internal-patch-for-repositories
branch
from
47f9c1e to
d83fd0b
Compare
kit-ty-kate
commented
Mar 27, 2024
kit-ty-kate
commented
Mar 27, 2024
kit-ty-kate
commented
Apr 2, 2024
kit-ty-kate
commented
Apr 2, 2024
kit-ty-kate
force-pushed
the
internal-patch-for-repositories
branch
from
2841797 to
6a05509
Compare
kit-ty-kate
force-pushed
the
internal-patch-for-repositories
branch
from
10a485e to
6da29f1
Compare
kit-ty-kate
changed the title
kit-ty-kate
force-pushed
the
internal-patch-for-repositories
branch
from
6d73281 to
d133309
Compare
kit-ty-kate
force-pushed
the
internal-patch-for-repositories
branch
2 times, most recently
from
93d5eb8 to
b32bcea
Compare
rjbou
reviewed
Mar 18, 2025
There was a problem hiding this comment.
Great & huge work!! Some comments on small thing, but in the idea and how it is done 💯
I'm wondering if we should have some reftest for it ? Or patch library test are enough ?
On testing, can you confirm that all opam repo patches are handled?
I think also that the single commit should be split, per "change" : * add patch lib
- change patch function to use lib & remove the tool dependency
- change diff function to use lib & remove the tool dependency
kit-ty-kate
commented
Mar 20, 2025
rjbou
reviewed
Mar 25, 2025
kit-ty-kate
force-pushed
the
internal-patch-for-repositories
branch
from
83dfa03 to
82d3207
Compare
|
History cleaned |
kit-ty-kate
force-pushed
the
internal-patch-for-repositories
branch
from
82d3207 to
7bdf02a
Compare
kit-ty-kate
force-pushed
the
internal-patch-for-repositories
branch
from
7bdf02a to
c2b5fcf
Compare
kit-ty-kate
force-pushed
the
internal-patch-for-repositories
branch
from
c2b5fcf to
920f7c5
Compare
kit-ty-kate
force-pushed
the
internal-patch-for-repositories
branch
from
920f7c5 to
9ad9ef5
Compare
|
@kit-ty-kate thanks. Great work :-) |
This was referenced Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6019
Fixes #3782 by removing any handling of chmod entirely (git extensions). Every patched files keep their permissions and every new file has the default file permission (644).
Fixes ocaml/setup-ocaml#933
Fixes #6052
see #5891
A large amount of work was necessary in the
patchlibrary to make this work. See hannesm/patch#9, hannesm/patch#7 and especially hannesm/patch#22Moving the logic of
OpamSystem.translate_patchintopatchcan be done later. Possibly during the 2.4 alpha phase.The 2.4 alpha phase will also serve to test this new version of patch (3.0.0), once it has been sufficiently tested the stable release of
patch.3.0.0will be published.