Fix opam tree --test --doc assigning the with-{test,doc} variables to unrequested packages #5919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
force-pushed
the
fix-wrong-var-assign-tree
branch
from
ab70c2a to
cda67cb
Compare
rjbou
reviewed
May 3, 2024
kit-ty-kate
force-pushed
the
fix-wrong-var-assign-tree
branch
from
b1b779d to
3e2f531
Compare
kit-ty-kate
changed the title
kit-ty-kate
force-pushed
the
fix-wrong-var-assign-tree
branch
from
3e2f531 to
f7b1754
Compare
…bles in their dependencies (second level)
rjbou
force-pushed
the
fix-wrong-var-assign-tree
branch
from
25d2e22 to
3781f29
Compare
rjbou
reviewed
May 3, 2024
kit-ty-kate
force-pushed
the
fix-wrong-var-assign-tree
branch
from
36cd052 to
dc707b5
Compare
|
All cleaned up, squashed and ready to go. |
…ted packages Co-authored-by: Raja Boujbel <raja.boujbel@ocamlpro.com>
And more generally for simulated states, when packages need to be installed Co-authored-by: Raja Boujbel <raja.boujbel@ocamlpro.com>
rjbou
force-pushed
the
fix-wrong-var-assign-tree
branch
from
dc707b5 to
0973989
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5755
Fix #5920
OpamSwitchState.universewas called with~requested:st.installedso all the packages that were currently installed had theirwith-doc,with-test,with-dev-setupanddevvariables assigned instead of just the packages that were given as input to theopam treecommand.TODO:add a test (seeopam treecauses error when used with--with-doc#5755 (comment))